Skip to content

Commit

Permalink
Remove rust toolchain registration
Browse files Browse the repository at this point in the history
This doesn't alleviate Bazel's problem. rules_rust are still fetched because they register toolchains themselves.

However the change pushes into the direction, where I believe that only the owning module should be concerned with its toolchain registration and the toolchain selection should be controlled via a flag mechanism or similar. Removing the registration now, can alleviate problems in the future, when we figure out how to prevent unnecessary fetches.

PiperOrigin-RevId: 684721071
  • Loading branch information
protobuf-github-bot authored and copybara-github committed Oct 11, 2024
1 parent 9c4f3b8 commit 0bfe41b
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -128,14 +128,6 @@ pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip")

use_repo(pip, "pip_deps")

rust = use_extension("@rules_rust//rust:extensions.bzl", "rust")

rust.toolchain(edition = "2021")

use_repo(rust, "rust_toolchains")

register_toolchains("@rust_toolchains//:all")

crate = use_extension("@rules_rust//crate_universe:extension.bzl", "crate")

crate.spec(
Expand Down

0 comments on commit 0bfe41b

Please sign in to comment.