Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formula support in Xlsx style #76

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix formula support in Xlsx style #76

wants to merge 4 commits into from

Conversation

Yugam18
Copy link

@Yugam18 Yugam18 commented Jun 21, 2017

No description provided.

@pietersv
Copy link
Collaborator

pietersv commented Apr 19, 2018 •
edited
Loading

@yugam This is a useful fix. We'll aim to incorporate this if we open the branch for new development. Generally for changes we need to make sure that:

  • changes are to the source code in the /bits/ directory rather than to xlsx.js (which is generated and overwritten by the make process)
  • add a unit test to verify this works
  • verify the test suite passes

@pietersv pietersv mentioned this pull request Apr 19, 2018
Open
suhli pushed a commit to suhli/node-xlsx that referenced this pull request Apr 24, 2021
support formula
6ca9965 
ref pr:protobi/js-xlsx#76
ref issue:protobi/js-xlsx#75
ekossystem
ekossystem reviewed Oct 11, 2021
View reviewed changes
Copy link

@ekossystem ekossystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyone can merge this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekossystem ekossystem ekossystem left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yugam18 @pietersv @ekossystem