Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize domain before starting engine #453

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

subhashb
Copy link
Contributor

This ensures that all domain elements are registered and all adapters are initialized before the server starts processing messages.

@subhashb subhashb self-assigned this Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.34%. Comparing base (97a2dde) to head (cd1cd2d).

Files Patch % Lines
src/protean/server/engine.py 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #453      +/-   ##
==========================================
+ Coverage   89.81%   90.34%   +0.53%     
==========================================
  Files          71       71              
  Lines        6000     6009       +9     
  Branches     1203     1205       +2     
==========================================
+ Hits         5389     5429      +40     
+ Misses        458      425      -33     
- Partials      153      155       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhashb subhashb merged commit 01549e7 into main Aug 12, 2024
6 checks passed
@subhashb subhashb deleted the initialize-domain-before-starting-engine branch August 12, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant