Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run subscribers within Engine #451

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Run subscribers within Engine #451

merged 2 commits into from
Aug 8, 2024

Conversation

subhashb
Copy link
Contributor

@subhashb subhashb commented Aug 7, 2024

This commit allows the Protean Engine to track and run broker subscribers to consume messages as they arrive on the broker channel.

This commit allows the engine to track and run subscribers, to consume messages
as they arrive on the broker channel.
@subhashb subhashb self-assigned this Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 95.45455% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.80%. Comparing base (5fd6580) to head (553b410).

Files Patch % Lines
src/protean/server/broker_subscription.py 90.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #451      +/-   ##
==========================================
+ Coverage   89.65%   89.80%   +0.15%     
==========================================
  Files          70       71       +1     
  Lines        5916     5996      +80     
  Branches     1193     1203      +10     
==========================================
+ Hits         5304     5385      +81     
- Misses        457      458       +1     
+ Partials      155      153       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhashb subhashb merged commit 792bf75 into main Aug 8, 2024
6 checks passed
@subhashb subhashb deleted the broker-engine-subscription branch August 8, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant