Assimilate Event Sourcing functionality into regular aggregates #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, Event Sourced Aggregate was a segarate domain element with its own class and factory. This causes a few issues: - A separate API for event sourced aggregates - Duplication of code between aggregate types - When a bug is fixed in one place, the other has to be take care too - Dissimilarities in functionality (Event sourced aggregates did not support invariants and entity nesting) This commit merges the functionality and introduces an option called `is_event_sourced` on BaseAggregate to control event sourcing behavior. The repository will remain as-is for now, because that's where event sourced aggregates primarily differ from regular aggregates. This will need to be revisited if we want to support custom event sourced repositories.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 88.92% 89.14% +0.21%
==========================================
Files 72 71 -1
Lines 6013 5959 -54
Branches 1201 1198 -3
==========================================
- Hits 5347 5312 -35
+ Misses 495 479 -16
+ Partials 171 168 -3 ☔ View full report in Codecov by Sentry. |
Event sourced aggregates so far were only limited to on aggregate, with no support for underlying entities. This commit allows event sourced aggregates to behave just like regular aggregates with multi-level heirarchies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, Event Sourced Aggregate was a segarate domain element with its own class and factory. This causes a few issues:
This commit merges the functionality and introduces an option called
is_event_sourcedon BaseAggregate to control event sourcing behavior. The repository will remain as-is for now, because that's where event sourced aggregates primarily differ from regular aggregates. This will need to be revisited if we want to support custom event sourced repositories.