Check for database provider access on Domain initialization #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a provider's configuration in invalid, we want to throw an exception as early as possible. This commit validates that a connection is indeed possible during `Domain.init` and throws a `ConfigurationError` exception on error.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #443 +/- ##
==========================================
+ Coverage 88.88% 88.91% +0.03%
==========================================
Files 71 71
Lines 5963 5981 +18
Branches 1185 1187 +2
==========================================
+ Hits 5300 5318 +18
Misses 492 492
Partials 171 171 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to throw an exception immediately if a provider's configuration is invalid. This commit validates that a connection is possible for every configured provider during
Domain.initand throws aConfigurationErrorexception on error.