Stream Enhancements #441
Merged
Stream Enhancements #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contains: - Unify metadata in Event and Command objects - Remove `MessageMetadata` class - Build Message metadata directly from event/command object - Introduce `kind`, `stream_name`, and `origin_stream_name` to metadata - Initialize event store in `init` - Don't build stream name in different places. Use `.meta_stream_name`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
+ Coverage 87.93% 88.79% +0.85%
==========================================
Files 71 71
Lines 5986 5962 -24
Branches 1202 1186 -16
==========================================
+ Hits 5264 5294 +30
+ Misses 525 496 -29
+ Partials 197 172 -25 ☔ View full report in Codecov by Sentry. |
Changes: - Ensure stream names have aggregate id within them - Use `stream_name` in Event/Command metadata as-is for persistence into event store - Base handlers and handler retreival on stream name - Ensure commands always belong to an aggregate cluster - Remove `stream_name` option from events and and commands All elements in an aggregate cluster should use the aggregate's stream name - Enhance `Domain.process` to enrich command before processing
Changes: - Add `_event_position` temp variable in aggregates to track last event position in event store - Track expected version per event with `_event_position` - Fetch last event position on aggregate load and update `_event_position` - Unify method to append event to event store in aggregates and event sourced aggregates - Unify method to construct message from event for aggregates and event sourced aggregates - Track database state within the memory provider instead of a global object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
MessageMetadataclasskind,stream_name, andorigin_stream_nameto metadatainit.meta_stream_name