Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable VSCode Testing to scan tests successfully #435

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

subhashb
Copy link
Contributor

@subhashb subhashb commented Jun 9, 2024

Changes:

  • Avoid using current_domain where domain object is readily accessible
  • Rename test_domains directory to domains in tests/support
  • Add tests/support to ignore path in .vscode/settings file
  • Change files to throw OutOfContextError now that there is no import time access to OutOfContextError

Changes:
- Avoid using `current_domain` where domain object is readily accessible
- Rename `test_domains` directory to `domains` in `tests/support`
- Add `tests/support` to ignore path in .vscode/settings file
- Change files to throw OutOfContextError now that there is no import time
access to OutOfContextError
@subhashb subhashb self-assigned this Jun 9, 2024
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (155aa2c) to head (7b28c13).
Report is 64 commits behind head on main.

Files Patch % Lines
src/protean/adapters/repository/sqlalchemy.py 33.33% 2 Missing and 2 partials ⚠️
src/protean/fields/basic.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #435      +/-   ##
==========================================
+ Coverage   84.53%   86.73%   +2.20%     
==========================================
  Files          70       72       +2     
  Lines        5361     5798     +437     
  Branches      981     1142     +161     
==========================================
+ Hits         4532     5029     +497     
+ Misses        630      558      -72     
- Partials      199      211      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhashb subhashb merged commit ba96b80 into main Jun 9, 2024
4 of 6 checks passed
@subhashb subhashb deleted the enable-vscode-testing branch June 9, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant