Remove support for inner Meta class
#433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes support for inner `Meta` class to define options. With this change: 1. All domain elements have to be registered with their respective decorators 2. Elements can be optionally declared and registered separately, passing the options to the `domain.register` method 3. Subclassing does not inherit Meta options 4. Element options will only be valid after registering with domain 5. Base classes will throw `NotSupportedError` on instantiation, instead of `TypeError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes support for inner
Metaclass to define options. With this change:domain.registermethodNotSupportedErroron instantiation, instead ofTypeError.