Resolve references when initializing Domain #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves resolving references, as well as validating domain constructs to domain initialization, not activation. This ensures they happen one time, at the beginning of domain setup. If they are in activation, the resolution would be triggered every time a domain context is activated, which would be every time the domain processes a request! This commit also has the following fixes: * Ensure Value Object field's class resolution works * All Events and Commands need to be associated with an Aggregate or a stream * Validation to ensure events are not associated with multiple event sourced aggregates * Allow Abstract events and commands to be defined without an Aggregate or a stream * Scope `setup_db` fixtures to Module level (Having them at `session` level was resulting in the wrong context being popped) * Move `fetch_element_cls_from_registry` under Domain object to avoid using `current_domain` * Pass `domain` during class resolution to avoid using `current_domain`
- Simplify element resolution and trigger in `init()` - Resolve classes in Meta linkages (specifically `meta_.aggregate_cls`) - Add missing `domain.init()` statements in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request moves resolving references, as well as validating domain constructs to domain initialization (
domain.init()), not activation (domain.domain.context().push()). This ensures they happen one time, at the beginning of domain setup. If they are in activation, the resolution would be triggered every time a domain context is activated, which would be every time the domain processes a request!This commit also has the following fixes:
setup_dbfixtures to Module level (Having them atsessionlevelwas resulting in the wrong context being popped)
fetch_element_cls_from_registryunder Domain object to avoid usingcurrent_domaindomainduring class resolution to avoid usingcurrent_domainmeta_.aggregate_cls)domain.init()statements in tests