Async server bug fixes and general enhancements #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom validators in VOs were not being fired because Protean was only firing validators at the Entity's field level. This change ensures custom validators inside the VO, which are one level deeper, are also fired.
Value Objects do not have identifiable features, so should not have fields that indicate uniqueness like `unique` or `identifier` flags.
Value objects should not be editable. This commit ensures that VOs cannot be updated once initialized, but aggregates/entities can switch VOs when they want to perform changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes and general enhancements to Engine and Subscription
handle_errormethod in Command and Event handlersexit_codewith engine runThis PR also has changes to: