Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Traversal Refactoring #398

Merged
merged 6 commits into from
Mar 16, 2024
Merged

Domain Traversal Refactoring #398

merged 6 commits into from
Mar 16, 2024

Conversation

subhashb
Copy link
Contributor

@subhashb subhashb commented Mar 16, 2024

This PR contains the following fixes:

  • Changes how domain.init() traverses the file structure
  • Require domain to be initialized with __file__ (Breaking Change)
  • Fixed with SQLAlchemy model generation
  • Fixed inconsistencies in the usage of the schema-name attribute in Models
  • Cleaned up test domain initialization
  • Removed naive MULTI_TENANCY implementation
  • Upgraded packages

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 84.23%. Comparing base (9955576) to head (89ce70d).

Files Patch % Lines
src/protean/cli.py 0.00% 8 Missing ⚠️
src/protean/adapters/repository/__init__.py 0.00% 1 Missing and 1 partial ⚠️
src/protean/adapters/repository/elasticsearch.py 50.00% 1 Missing ⚠️
src/protean/adapters/repository/sqlalchemy.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   84.31%   84.23%   -0.08%     
==========================================
  Files          67       67              
  Lines        5290     5297       +7     
  Branches      978      979       +1     
==========================================
+ Hits         4460     4462       +2     
- Misses        631      636       +5     
  Partials      199      199              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhashb subhashb merged commit aac52d6 into master Mar 16, 2024
3 of 5 checks passed
@subhashb subhashb deleted the domain-traversal-refactoring branch March 16, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant