Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control domain directory traversal explicitly in init() #391

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

subhashb
Copy link
Contributor

@subhashb subhashb commented Dec 6, 2023

By default, Protean will try to traverse the domain's directory to discover elements.

The flag traverse can be used to skip traversing the directory if the entire domain code is in a single file or the elements are being registered manually.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (166ee83) 84.31% compared to head (f56ecda) 84.31%.

Files Patch % Lines
src/protean/domain/__init__.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #391   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files          67       67           
  Lines        5290     5290           
  Branches      978      978           
=======================================
  Hits         4460     4460           
  Misses        631      631           
  Partials      199      199           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@subhashb subhashb merged commit 71afcfd into master Dec 6, 2023
4 of 5 checks passed
@subhashb subhashb deleted the control-domain-dir-traversal branch December 6, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant