Rename MemoryBroker to InlineBroker

Also remove unused RQ Broker Adapter
proteanhq · Sep 24, 2020 · bec09c7 · bec09c7
1 parent 4077b9f
commit bec09c7
Show file tree

Hide file tree

Showing 10 changed files with 14 additions and 14 deletions.
diff --git a/src/protean/adapters/broker/memory_broker.py → src/protean/adapters/broker/inline_broker.py b/src/protean/adapters/broker/memory_broker.py → src/protean/adapters/broker/inline_broker.py
@@ -5,11 +5,11 @@
 from protean.utils import fully_qualified_name
 
 
-class MemoryBroker(BaseBroker):
+class InlineBroker(BaseBroker):
     def __init__(self, name, domain, conn_info):
         super().__init__(name, domain, conn_info)
 
-        # In case of `MemoryBroker`, the `IS_ASYNC` value will always be `False`.
+        # In case of `InlineBroker`, the `IS_ASYNC` value will always be `False`.
         conn_info["IS_ASYNC"] = False
 
     def send_message(self, initiator_obj):

diff --git a/src/protean/domain/__init__.py b/src/protean/domain/__init__.py
@@ -95,7 +95,7 @@ class Domain(_PackageBoundObject):
             },
             "BROKERS": {
                 "default": {
-                    "PROVIDER": "protean.adapters.broker.memory_broker.MemoryBroker",
+                    "PROVIDER": "protean.adapters.broker.inline_broker.InlineBroker",
                 },
             },
             "EMAIL_PROVIDERS": {

diff --git a/tests/adapters/email/sendgrid_email/config.py b/tests/adapters/email/sendgrid_email/config.py
@@ -36,7 +36,7 @@
 
 # Messaging Mediums
 BROKERS = {
-    "default": {"PROVIDER": "protean.adapters.broker.memory_broker.MemoryBroker"},
+    "default": {"PROVIDER": "protean.adapters.broker.inline_broker.InlineBroker"},
 }
 
 EMAIL_PROVIDERS = {

diff --git a/tests/broker/tests.py b/tests/broker/tests.py
@@ -2,7 +2,7 @@
 import pytest
 
 from protean.port.broker import BaseBroker
-from protean.adapters.broker.memory_broker import MemoryBroker
+from protean.adapters.broker.inline_broker import InlineBroker
 
 
 class TestBroker:
@@ -11,10 +11,10 @@ def test_that_base_broker_class_cannot_be_instantiated(self):
             BaseBroker()
 
     def test_that_a_concrete_broker_can_be_initialized_successfully(self, test_domain):
-        broker = MemoryBroker("dummy_name", test_domain, {})
+        broker = InlineBroker("dummy_name", test_domain, {})
 
         assert broker is not None
 
     def test_that_domain_initializes_broker_from_config(self, test_domain):
         assert len(list(test_domain.brokers)) == 1
-        assert isinstance(list(test_domain.brokers.values())[0], MemoryBroker)
+        assert isinstance(list(test_domain.brokers.values())[0], InlineBroker)
diff --git a/tests/config.py b/tests/config.py
@@ -40,7 +40,7 @@
 
 # Messaging Mediums
 BROKERS = {
-    "default": {"PROVIDER": "protean.adapters.broker.memory_broker.MemoryBroker"},
+    "default": {"PROVIDER": "protean.adapters.broker.inline_broker.InlineBroker"},
 }
 
 EMAIL_PROVIDERS = {

diff --git a/tests/configuration/tests.py b/tests/configuration/tests.py
@@ -39,7 +39,7 @@ def test_config_repr(self):
             "'IDENTITY_STRATEGY': <IdentityStrategy.UUID: 1>, "
             "'IDENTITY_TYPE': <IdentityType.STRING: 'STRING'>, "
             "'DATABASES': {'default': {'PROVIDER': 'protean.adapters.repository.memory.MemoryProvider'}}, "
-            "'BROKERS': {'default': {'PROVIDER': 'protean.adapters.broker.memory_broker.MemoryBroker'}}, "
+            "'BROKERS': {'default': {'PROVIDER': 'protean.adapters.broker.inline_broker.InlineBroker'}}, "
             "'EMAIL_PROVIDERS': {'default': {'PROVIDER': 'protean.adapters.email.dummy.DummyEmailProvider', "
             "'DEFAULT_FROM_EMAIL': '[email protected]'}}, "
             "'AGGREGATE_CHILDREN_LIMIT': 100, "

diff --git a/tests/domain_event/tests.py b/tests/domain_event/tests.py
@@ -4,7 +4,7 @@
 from mock import patch
 from protean.core.domain_event import BaseDomainEvent
 from protean.globals import current_domain
-from protean.adapters.broker.memory_broker import MemoryBroker
+from protean.adapters.broker.inline_broker import InlineBroker
 from protean.infra.event_log import EventLog, EventLogRepository
 from protean.utils import fully_qualified_name
 
@@ -41,7 +41,7 @@ def special_method(self):
 
 
 class TestDomainEventTriggering:
-    @patch.object(MemoryBroker, "send_message")
+    @patch.object(InlineBroker, "send_message")
     def test_that_domain_event_is_raised_in_aggregate_command_method(self, mock):
         newcomer = Person.add_newcomer(
             {"first_name": "John", "last_name": "Doe", "age": 21}

diff --git a/tests/identity/config_int.py b/tests/identity/config_int.py
@@ -23,5 +23,5 @@
 
 # Messaging Mediums
 BROKERS = {
-    "default": {"PROVIDER": "protean.adapters.broker.memory_broker.MemoryBroker"},
+    "default": {"PROVIDER": "protean.adapters.broker.inline_broker.InlineBroker"},
 }
diff --git a/tests/identity/config_string.py b/tests/identity/config_string.py
@@ -25,5 +25,5 @@
 
 # Messaging Mediums
 BROKERS = {
-    "default": {"PROVIDER": "protean.adapters.broker.memory_broker.MemoryBroker"},
+    "default": {"PROVIDER": "protean.adapters.broker.inline_broker.InlineBroker"},
 }
diff --git a/tests/identity/config_uuid.py b/tests/identity/config_uuid.py
@@ -25,5 +25,5 @@
 
 # Messaging Mediums
 BROKERS = {
-    "default": {"PROVIDER": "protean.adapters.broker.memory_broker.MemoryBroker"},
+    "default": {"PROVIDER": "protean.adapters.broker.inline_broker.InlineBroker"},
 }