Skip to content

Commit

Permalink
Reverting to the ENV as I can't seem to make the GitHub flow create t…
Browse files Browse the repository at this point in the history
…he ENV
  • Loading branch information
chargio committed Nov 15, 2024
1 parent 7a9750d commit 777d1ce
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/docker-image.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,6 @@ jobs:
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}

# Workaround for the problem with QEMU. Delete as soon as QEMU 8.1 is part of the build
- name: Set env
run: echo ERL_FLAGS="+JMsingle true" >> $GITHUB_ENV
- name: Build and push the Docker image
uses: docker/build-push-action@v6
with:
Expand Down
5 changes: 1 addition & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,7 @@ RUN mix local.hex --force && \
ENV MIX_ENV="prod"
# Add JPperf as workaround for the failure on building the code in Github actions
# It should not be necessary with QEMU 8.1, and it introduces some security issues, so delete as as soon as possible
# ENV ERL_FLAGS="+JMsingle true"
ARG ERL_FLAGS=""
ENV ERL_FLAGS=${ERL_FLAGS}
RUN echo "ERL FLAGS FOR THE BUILD: " $ERL_FLAGS
ENV ERL_FLAGS="+JMsingle true"


# install mix dependencies
Expand Down

0 comments on commit 777d1ce

Please sign in to comment.