improve documentation for integrating with GitLab CI #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing pronto in our GitLab CI we ran into an issue when having more than 50 commits in an MR. In this case, pronto simply showed all issues, not only the ones in our changes.
The cause of this was GitLabs git depth (50 by default for us, 20 on newer installations). Unfortunately, it is not enough to separately fetch the target branch (which was already present in the docs), but also to refetch the history of HEAD beyond the initial fetch depth.
You could also do this explicitely, by I found it cleaner to simply disable the git depth for this one job.
In case others stumble upon the same problem, I want to update the docs a bit to reflect this need of disabling git depth.