Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relax octokit dependency to allow releases up to 9.0 #454

Closed
wants to merge 1 commit into from
Closed

relax octokit dependency to allow releases up to 9.0 #454

wants to merge 1 commit into from

Conversation

ashkulz
Copy link
Member

@ashkulz ashkulz commented Nov 2, 2023

fixes #453

@ashkulz ashkulz requested a review from a team as a code owner November 2, 2023 04:02
@pbstriker38
Copy link
Contributor

You can't allow Octokit 8.0 without fixing the argument being passed to create_pull_comment. Pronto is sending position and Octokit is sending that to the API as line. So it will either return a 422 if the position does not map to a valid line or put the comment on the wrong line.

I'm working on a fix and I'll have a PR open shortly.

@ashkulz
Copy link
Member Author

ashkulz commented Nov 3, 2023

Thanks, I was going to work on it but you beat me to it 🙂

@ashkulz ashkulz closed this Nov 3, 2023
@ashkulz ashkulz deleted the octokit_8.0 branch November 3, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Octokit 8.0
2 participants
@ashkulz @pbstriker38