Removing old bitbucket pull request commits #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ashkulz
requested changes
Jan 2, 2023
| @@ -41,6 +41,12 @@ def grouped_comments(comments) | |||
| comments.group_by { |comment| [comment.path, comment.position] } | |||
| end | |||
|
|
|||
| def ungrouped_comments(comments) | |||
There was a problem hiding this comment.
I don't see why this should be in git_formatter, should directly be in bitbucket_pull_request_formatter.
|
|
||
| submit_comments(client, additions) | ||
|
|
||
| approve_pull_request(comments.count, additions.count, client) if defined?(approve_pull_request) |
There was a problem hiding this comment.
Why do you need to check this? It's defined below.
Comment on lines
+8
to
+10
| additions = remove_duplicate_comments(existing, comments) | ||
|
|
||
| remove_comments(client, existing, comments) if existing.any? |
There was a problem hiding this comment.
This should be optional. I'm not sure how we'd go about it, maybe a separate PullRequestFormatter which deletes comments?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #255 for Bitbucket Pull Request format.