add trustStore and needClientAuth config to yaml (#834) #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
peeking at that test failure.. sorted! |
Signed-off-by: Gary Tully <[email protected]>
|
if it helps, for some context, the yaml for this use case is produced at: https://github.com/gtully/activemq-artemis-operator/blob/_jmx_exporter_agent/controllers/activemqartemis_reconciler.go#L2096 |
dhoard
reviewed
Jan 17, 2025
Comment on lines
+133
to
+137
| try { | ||
| HttpResponse httpResponse = HttpClient.sendRequest(url); | ||
| throw new AssertionFailedError("expected exception on no client cert"); | ||
| } catch (Exception expectedOnNoClientCert) { | ||
| } |
There was a problem hiding this comment.
Change this to use Assertj assertThatExceptionOfType
| km.getKeyManagers(), tm.getTrustManagers(), new java.security.SecureRandom()); | ||
|
|
||
| return sslContext; | ||
| } catch (IOException |
There was a problem hiding this comment.
Why are we catching exceptions and logging them?
| @@ -0,0 +1,277 @@ | |||
| /* | |||
| * Copyright (C) 2023-present The Prometheus jmx_exporter Authors | |||
There was a problem hiding this comment.
Change the copyright year since this is a new file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dhoard I am making use of the custom authenticator and want to grant permissions based on the clients certificate so I need to be able to configure needClientAuth on the ssl parameters. Also, in kube land, I need to be able to configure the key and trust store types to support PEM key stores. Having these exposed in the yaml config leaves the system properties free for others.
From what I understand, this additional truststore config will also help with #834