Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper: Update space section #2597

Merged
merged 3 commits into from
Jan 5, 2025
Merged

paper: Update space section #2597

merged 3 commits into from
Jan 5, 2025

Conversation

jackiekazil
Copy link
Member

This took longer than I wanted, but I hope this gets at what I thought needed to be edited in this section.
The edits include:

  • Explicitly highlight new additions in Mesa 3, so readers understand what has changed
  • Explicitly highlight how/where to import from while these things are in the experimental stage
  • Other minor wording/grammar updates

Let me know if something needs to be adjusted.
Related: #2559

@jackiekazil jackiekazil requested a review from EwoutH January 5, 2025 07:06
@jackiekazil jackiekazil mentioned this pull request Jan 5, 2025
14 tasks
Copy link
Member

@quaquel quaquel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done. I think this strikes a middle ground between what I would prefer and what @jackiekazil has been arguing for.

Copy link
Member

@EwoutH EwoutH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@jackiekazil
Copy link
Member Author

Thank you both!

@jackiekazil jackiekazil merged commit 066007e into paper_2024 Jan 5, 2025
3 checks passed
@EwoutH EwoutH deleted the jk/paper_2024 branch January 7, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants