Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.30: Bump Envoy to v1.31.3 and Go to v1.22.8 #6715

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

tsaarni
Copy link
Member

@tsaarni tsaarni commented Oct 19, 2024

This change updates release-1.30 branch with

  • envoy v1.31.3
    • See release notes for v1.31.1 here.
    • See release notes for v1.31.2 here.
    • See release notes for v1.31.3 here.
  • go v1.22.8
    • See release notes here.

@tsaarni tsaarni requested a review from a team as a code owner October 19, 2024 08:20
@tsaarni tsaarni requested review from skriss and sunjayBhatia and removed request for a team October 19, 2024 08:20
@sunjayBhatia sunjayBhatia requested review from a team, rajatvig and izturn and removed request for a team October 19, 2024 08:20
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.30@93064bd). Learn more about missing BASE report.
Report is 1 commits behind head on release-1.30.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release-1.30    #6715   +/-   ##
===============================================
  Coverage                ?   81.01%           
===============================================
  Files                   ?      133           
  Lines                   ?    19994           
  Branches                ?        0           
===============================================
  Hits                    ?    16198           
  Misses                  ?     3503           
  Partials                ?      293           
Files with missing lines Coverage Δ
cmd/contour/gatewayprovisioner.go 43.87% <100.00%> (ø)

@tsaarni tsaarni changed the title release-1.30: Bump Envoy to v1.31.2 release-1.30: Bump Envoy to v1.31.2 and Go to v1.22.8 Oct 19, 2024
@tsaarni tsaarni mentioned this pull request Oct 21, 2024
Makefile Outdated
@@ -44,7 +44,7 @@ endif
IMAGE_PLATFORMS ?= linux/amd64,linux/arm64

# Base build image to use.
BUILD_BASE_IMAGE ?= golang:1.22.5@sha256:829eff99a4b2abffe68f6a3847337bf6455d69d17e49ec1a97dac78834754bd6
BUILD_BASE_IMAGE ?= golang:1.22.8@sha256:9f7fab27a7199abd0902daf34abf1e93aca4bafda4228bd303fdd7b4cbfab082
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: just curious where this digest came from? seeing a different one here: https://hub.docker.com/layers/library/golang/1.22.8/images/sha256-9e7db50b9858e9cd804043200f1e6acd5a11111151ce886951c9fe3523002cea?context=explore

sha256:0ca97f4ab335f4b284a5b8190980c7cdc21d320d529f2b643e8a8733a69bfb6b

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the same page (or at least intended to), but you’re right. I will make the update. It seems they might be pushing updates and moving the tags but since Dockerhub does not log the history of previous pushes, I cannot confirm.

I worked on this around midday of October 19, and the image page shows "Last pushed 3 days ago" and when hovering over "Oct 19, 2024 at 2:22 pm," although it doesn’t mention the timezone. When checking the Makefile for the previous Go version 1.22.5, we have the hash
sha256:829eff99a4b2abffe68f6a3847337bf6455d69d17e49ec1a97dac78834754bd6
but now the 1.22.5 page shows a different hash sha256:86a3c48a61915a8c62c0e1d7594730399caa3feb73655dfe96c7bc17710e96cf.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yeah that is an interesting/unfortunate one if the team building those images is repushing over the same tag

Signed-off-by: Tero Saarni <[email protected]>
Signed-off-by: Tero Saarni <[email protected]>
Signed-off-by: Tero Saarni <[email protected]>
@tsaarni tsaarni merged commit 2c9109a into projectcontour:release-1.30 Nov 4, 2024
19 checks passed
@tsaarni tsaarni changed the title release-1.30: Bump Envoy to v1.31.2 and Go to v1.22.8 release-1.30: Bump Envoy to v1.31.3 and Go to v1.22.8 Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants