Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump sigs.k8s.io/kustomize/kyaml from 0.17.2 to 0.18.1 #6701

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 13, 2024

Bumps sigs.k8s.io/kustomize/kyaml from 0.17.2 to 0.18.1.

Release notes

Sourced from sigs.k8s.io/kustomize/kyaml's releases.

kyaml/v0.18.1

This is a patch release of kyaml that was created due to a defect in the release process. Please check https://github.com/kubernetes-sigs/kustomize/releases/tag/kyaml%2Fv0.18.0

kyaml/v0.18.0

Breaking change

A starlark support for krm functions was removed to cleanup dependencies. kubernetes-sigs/kustomize#5768 This feature was deprecated long ago and removed because there was no desire to continue using it. kubernetes-sigs/kustomize#5768

What's Changed

New Contributors

Full Changelog: kubernetes-sigs/kustomize@kustomize/v5.4.3...kyaml/v0.18.0

api/v0.18.0

Breaking change

#5768: Remove starlark support

Feature

#5751: Add --helm-debug Flag to Kustomize for Enhanced Helm Debugging

Fix Bugs

#5458: Sort built-in Namespace kind before CRDs with the same name #5745: Add Annotation to Control Inline List Conversion in Kustomize Resources"

Dependencies

#5781: Update kyaml to v0.18.1 #5763: Update go 1.22.7

api/v0.17.3

chore

#5506: fix some comments #5693: fix: always show accumulation errors #5699: chore: add deprecation comment to commonLabels #5698: fix(namereference): add configuration for new admission API

... (truncated)

Commits
  • 01cce4f Merge pull request #5756 from viniciusdc/5755-kustomize-install
  • 54cbcdc Merge pull request #5770 from koba1t/add_write_permission_to_run_release_CI
  • b36b222 add write permission to run release CI
  • 2cd9a2e Merge pull request #5768 from dims/remove-starlark-support
  • d32eacf Remove starlark support
  • 88f19bf Merge pull request #5763 from koba1t/update_go_1.22.7
  • a3c0b4a disable for a step to skip test when that is docs PR
  • b67ce5b go work sync && ./hack/doGoMod.sh tidy
  • 5ba8523 update go 1.22.7
  • 4034e36 Add --helm-debug Flag to Kustomize for Enhanced Helm Debugging (#5751)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner October 13, 2024 20:17
@dependabot dependabot bot added area/dependency Issues or PRs related to dependency changes. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes. labels Oct 13, 2024
@dependabot dependabot bot requested review from skriss, sunjayBhatia, a team and clayton-gonsalves and removed request for a team October 13, 2024 20:17
@dependabot dependabot bot requested review from rajatvig and tsaarni October 13, 2024 20:17
@sunjayBhatia sunjayBhatia requested a review from a team October 13, 2024 20:17
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/kustomize/kyaml-0.18.1 branch from bc74976 to 31c980f Compare October 21, 2024 15:32
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/kustomize/kyaml-0.18.1 branch 2 times, most recently from 87c47f7 to f04816c Compare October 21, 2024 22:40
@tsaarni
Copy link
Member

tsaarni commented Oct 22, 2024

This is again toolchain issue, similar to #6709.

The failure can be reproduced when running this patch locally::

$ make lint
Running Go linter ...
ERRO Running error: context loading failed: no go files to analyze
exit status 5
make: *** [Makefile:197: lint-golint] Error 1

If doing the version bump manually golangci-lint will succeed

$ go get sigs.k8s.io/kustomize/[email protected]
go: sigs.k8s.io/kustomize/[email protected] requires go >= 1.22.7; switching to go1.22.8
go: upgraded go 1.22.0 => 1.22.7
go: added toolchain go1.22.8
go: upgraded sigs.k8s.io/kustomize/kyaml v0.17.2 => v0.18.1
$ go version
go version go1.22.8 linux/amd64
$ make lint
Running Go linter ...
Running YAML linter ...

The difference is that dependabot patch does not update to minimum go language version level in go.mod which go get ... or go mod tidy will do:

-go 1.22.0
+go 1.22.7

@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/kustomize/kyaml-0.18.1 branch from f04816c to 6208430 Compare November 4, 2024 08:03
@tsaarni
Copy link
Member

tsaarni commented Nov 8, 2024

@dependabot rebase

Bumps [sigs.k8s.io/kustomize/kyaml](https://github.com/kubernetes-sigs/kustomize) from 0.17.2 to 0.18.1.
- [Release notes](https://github.com/kubernetes-sigs/kustomize/releases)
- [Commits](kubernetes-sigs/kustomize@api/v0.17.2...kyaml/v0.18.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/kustomize/kyaml
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/main/sigs.k8s.io/kustomize/kyaml-0.18.1 branch from 6208430 to 0644c11 Compare November 8, 2024 17:07
* Update minimum go version in go.mod

Signed-off-by: Tero Saarni <[email protected]>
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (2659222) to head (bb9300d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6701   +/-   ##
=======================================
  Coverage   81.03%   81.03%           
=======================================
  Files         133      133           
  Lines       20006    20006           
=======================================
  Hits        16212    16212           
  Misses       3500     3500           
  Partials      294      294           

@tsaarni tsaarni merged commit 3921fa2 into main Nov 8, 2024
26 checks passed
@dependabot dependabot bot deleted the dependabot/go_modules/main/sigs.k8s.io/kustomize/kyaml-0.18.1 branch November 8, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes. release-note/none-required Marks a PR as not requiring a release note. Should only be used for very small changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants