shutdown manager: use filter on downstream_cx_active stats url (#6523)

Add a filter to prometheus stats url so that only the desired stats are returned. This improves the performance especially in clusters with high number of routes Signed-off-by: Ahmad Karimi <[email protected]>
projectcontour · Jun 20, 2024 · db4092e · db4092e
1 parent 9f25ff6
commit db4092e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelogs/unreleased/6523-therealak12-small.md b/changelogs/unreleased/6523-therealak12-small.md
@@ -0,0 +1 @@
+Improve shutdown manager query to the Envoy stats endpoint for active connections by utilizing a regex filter query param.
diff --git a/cmd/contour/shutdownmanager.go b/cmd/contour/shutdownmanager.go
@@ -31,7 +31,9 @@ import (
 )
 
 const (
-	prometheusURL      = "http://unix/stats/prometheus"
+	// The prometheusURL is used to fetch the envoy metrics. Note that the filter
+	// value matches Envoy's raw stat names (i.e. those on the `/stats/` endpoint).
+	prometheusURL      = "http://unix/stats/prometheus?filter=^http\\..*\\.downstream_cx_active$"
 	healthcheckFailURL = "http://unix/healthcheck/fail"
 	prometheusStat     = "envoy_http_downstream_cx_active"
 )