Libva header fix #54
Closed
Libva header fix #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Observed build failure in A15 due to missing flags and due to inheritance declaration. Tracked-On: NA Signed-off-by: Ankit Agarwal <[email protected]>
As libmfxhw32 depends on libva headers, add libva_headers. Tests done: - Android boot in GVT-d - Camera preview and capture - Video playback and recording - adb reboot Tracked-On: OAM-126508 Signed-off-by: JeevakaPrabu <[email protected]>
sysopenci
added
Valid commit message
Pending Developer Approval
sysopenci
requested review from
dyang23,
feijiang1,
gkdeepa,
TianmiChen,
YuanjunHuang and
yyao3
TianmiChen
reviewed
Oct 18, 2024
| @@ -334,7 +334,7 @@ LOCAL_CFLAGS_64 := $(MFX_CFLAGS_INTERNAL_64) | |||
|
|
|||
| LOCAL_LDFLAGS := $(MFX_LOCAL_LDFLAGS_HW) | |||
|
|
|||
| LOCAL_HEADER_LIBRARIES := libmfx_headers | |||
| LOCAL_HEADER_LIBRARIES := libmfx_headers libva_headers | |||
There was a problem hiding this comment.
Hi Jeevaka, could you please share where libva_headers is declared in MediaSDK? I don't see it in this change. By the way, why do we need this change here? Is it for the compiling issue on Android 15?
Thanks,
Tianmi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.