Implement partial resync after IP set update failures #9674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any failure to update an IP set must either be spurious (EBUSY) or caused by a problem with _that_ IP set. Historically, we've done an expensive full resync if we hit either type of error. This PR changes that: - After the first 3 failures, it retries without any resync. This should deal more cheaply with EBUSY-type errors. - After that, it does a partial resync of the IP sets that we were attempting to update. This covers all cases I can think of that can cause an IP set update to fail. - After the 6th retry it does a full resync as before, just in case.
marvin-tigera
added
release-note-required
fasaxc
added
docs-not-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Any failure to update an IP set must either be spurious (EBUSY) or caused by a problem with that IP set. Historically, we've done an expensive full resync if we hit either type of error.
This PR changes that:
Related issues/PRs
Might help with CORE-10804
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.