fix: docs for upgrades to include CRD upgrade notes and added upgrade notes that apply for v3.28+ #9546
Conversation
… notes that apply for v3.28+
marvin-tigera
added
release-note-required
|
|
venkatamutyala
changed the title
| @@ -76,7 +86,13 @@ ownership of the helm resources to the new chart location. | |||
|
|
|||
| ## All other upgrades | |||
|
|
|||
| 1. Run the helm upgrade: | |||
| 1. Upgrade CRDs: | |||
There was a problem hiding this comment.
It's worth noting that as of just a few days ago, we merged a PR that removes the need for this step.
For reference: #9518
It moves management of these CRDs out of the helm chart and into our operator code, so that users won't need to perform this step 🎉
There was a problem hiding this comment.
This will only take effect in Calico v3.30 though, so what you have here is appropriate for older versions.
There was a problem hiding this comment.
How long until 3.30 is released? Would it make sense for me to break my PR into two different PRs? I suspect the note for v3.28+ will still apply after v3.30 is released?
There was a problem hiding this comment.
@venkatamutyala yep, I think it makes sense to split into two PRs - the v3.28+ note still applies, but the CRD upgrade bits can be split out separately.
I think the CRD upgrade change should just be applied directly to older branches (release-v3.29, release-v3.28) instead of going through master.
There was a problem hiding this comment.
I believe this PR can be closed out now.
marvin-tigera
removed
release-note-required
Description
Documentation updates.
Artifacthub's README.md upgrade steps did not match what was on: https://docs.tigera.io/calico/latest/operations/upgrading/kubernetes-upgrade#all-other-upgrades this PR is to bring them into sync.
Related issues/PRs
N/A
Todos
Release Note
Reminder for the reviewer
Make sure that this PR has the correct labels and milestone set.
Every PR needs one
docs-*label.docs-pr-required: This change requires a change to the documentation that has not been completed yet.docs-completed: This change has all necessary documentation completed.docs-not-required: This change has no user-facing impact and requires no docs.Every PR needs one
release-note-*label.release-note-required: This PR has user-facing changes. Most PRs should have this label.release-note-not-required: This PR has no user-facing changes.Other optional labels:
cherry-pick-candidate: This PR should be cherry-picked to an earlier release. For bug fixes only.needs-operator-pr: This PR is related to install and requires a corresponding change to the operator.