[release tool] fix hashrelease failure (#9661)

* fix checking if hashrelease already exists

* split hashrelease commands

* address review feedback

release/Makefile

@@ -30,9 +30,13 @@ ci: static-checks
 ###############################################################################
 # Hashrelease
 ###############################################################################
-.PHONY: hashrelease
-hashrelease: bin/release var-require-all-GITHUB_TOKEN
+.PHONY: hashrelease hashrelease-build hashrelease-publish
+hashrelease: hashrelease-build hashrelease-publish
+
+hashrelease-build: bin/release var-require-all-GITHUB_TOKEN
 	@bin/release hashrelease build
+
+hashrelease-publish: bin/release var-require-all-GITHUB_TOKEN
 	@bin/release hashrelease publish
 
 ###############################################################################

release/internal/hashreleaseserver/server.go

@@ -88,10 +88,17 @@ func remoteReleasesLibraryPath(user string) string {
 func HasHashrelease(hash string, cfg *Config) (bool, error) {
 	logrus.WithField("hash", hash).Debug("Checking if hashrelease exists")
 	out, err := runSSHCommand(cfg, fmt.Sprintf("cat %s | grep %s", remoteReleasesLibraryPath(cfg.User), hash))
-	if err == nil {
-		return strings.Contains(out, hash), nil
+	if err != nil {
+		if strings.Contains(err.Error(), "exited with status 1") {
+			// Process exited with status 1 is from grep when no match is found
+			logrus.WithError(err).Error("Hashrelease not found")
+			return false, nil
+		} else {
+			logrus.WithError(err).Error("Failed to check hashrelease library")
+			return false, err
+		}
 	}
-	return false, err
+	return strings.Contains(out, hash), nil
 }
 
 // SetHashreleaseAsLatest sets the hashrelease as the latest for the stream

release/internal/hashreleaseserver/ssh.go

@@ -71,7 +71,7 @@ func runSSHCommand(cfg *Config, command string) (string, error) {
 	defer session.Close()
 	var stdoutBuf bytes.Buffer
 	session.Stdout = &stdoutBuf
-	logrus.WithField("command", command).Info("Running command in remote host")
+	logrus.WithField("command", command).Debug("Running command in remote host")
 	if err := session.Run(command); err != nil {
 		return "", err
 	}