Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing where clause to temp table cte #5453

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

lcouzens
Copy link
Contributor

@lcouzens lcouzens commented Jan 17, 2025

Jira Ticket

COST-####

Description

This change will add a where clause to the CTE select from reporting_ocpgcpcostlineitem_project_daily_summary_temp since we delete from this table by ocp/year/month partitions.

Address the following error:
TrinoExternalError(type=EXTERNAL, name=HIVE_PARTITION_DROPPED_DURING_QUERY, message="Partition no longer exists: ocp_source=000000-0000-00000-99b1-6eb9bb36fe20/year=2025/month=01"

Testing

  1. Checkout Branch
  2. Restart Koku
  3. Hit endpoint or launch shell
    1. You should see ...
  4. Do more things...

Release Notes

  • proposed release note
* [COST-####](https://issues.redhat.com/browse/COST-####) Fix some things

@lcouzens lcouzens added the smoke-tests pr_check will build the image and run minimal required smokes label Jan 17, 2025
@lcouzens lcouzens requested review from a team as code owners January 17, 2025 18:01
@lcouzens lcouzens changed the title add new where clause to cte Add missing where clause to temp table cte Jan 17, 2025
@lcouzens lcouzens enabled auto-merge (squash) January 17, 2025 18:29
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.2%. Comparing base (931e759) to head (93c50d3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #5453   +/-   ##
=====================================
  Coverage   94.2%   94.2%           
=====================================
  Files        370     370           
  Lines      31539   31539           
  Branches    3378    3378           
=====================================
  Hits       29700   29700           
  Misses      1196    1196           
  Partials     643     643           

@lcouzens lcouzens merged commit db9fce8 into main Jan 17, 2025
14 checks passed
@lcouzens lcouzens deleted the add-where-condition branch January 17, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants