Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust vm latests values to be second to last day #5385

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

myersCody
Copy link
Contributor

Jira Ticket

COST-20

Description

This change will change the latest value to be the second to last day. The last day will always be partial data skewing the cpu and memory request amounts. So, we decided the best approach would be to switch the values to the second to last day.

Testing

  1. Load data and hit the endpoint:
                            "request": {
                                "cpu": {
                                    "value": 1.0,
                                    "units": "Core"
                                },
                                "memory": {
                                    "value": 2.0,
                                    "units": "GiB"
                                }
                            }

Release Notes

  • proposed release note
* [COST-20](https://issues.redhat.com/browse/COST-20) Adjust vm latest values to be second to last day

@myersCody myersCody requested review from a team as code owners November 14, 2024 14:07
@myersCody myersCody added the smoke-tests pr_check will build the image and run minimal required smokes label Nov 14, 2024
@myersCody
Copy link
Contributor Author

/retest

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.1%. Comparing base (52a10c7) to head (014b2ce).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5385     +/-   ##
=======================================
- Coverage   94.1%   94.1%   -0.0%     
=======================================
  Files        371     371             
  Lines      31552   31552             
  Branches    3385    3385             
=======================================
- Hits       29681   29678      -3     
- Misses      1210    1213      +3     
  Partials     661     661             

@myersCody myersCody enabled auto-merge (squash) November 14, 2024 14:47
@myersCody
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
smoke-tests pr_check will build the image and run minimal required smokes smokes-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants