-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move Hardware Guide to Knowledge Base #2669
Conversation
✅ Your preview is ready!
|
I do think that, somewhere in the Hardware section of the Recommended Tools, there should be a link to this KB article, in the same way that the recommendation pages for Password Managers and VPNs feature a link back to their respective KB article. |
This is unfortunate, a version was merged that I've never reviewed or approved :( Probably have to look through the hardware PR to check for other unknown changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell the change you mentioned from e037fd7 is the only change that was missing in the PR...
That might have been my mistake. |
Signed-off-by: Jonah Aragon <[email protected]> Signed-off-by: Daniel Gray <[email protected]>
This pull request has been mentioned on Privacy Guides. There might be relevant details there: https://discuss.privacyguides.net/t/2024-07-29-a58f090/19733/1 |
This pull request has been mentioned on Privacy Guides. There might be relevant details there: |
Changes proposed in this PR:
mkdocs.yml
is not consistent with the rest in the "Recommendations" section. In my opinion, this page being in the KB makes a lot of sense since it doesn't offer tool recommendations in the same way that other pages (like any of the recently split Android pages) do.Contribution terms (click to expand)
1) I am the sole author of this work. 2) I agree to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute my contribution as part of this project. 3) I have disclosed any relevant conflicts of interest in my post. 4) I agree to the Community Code of Conduct.