Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Signal username information #2079

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add Signal username information #2079

merged 1 commit into from
Feb 20, 2024

Conversation

jonaharagon
Copy link
Member

@jonaharagon jonaharagon commented Mar 8, 2023 •
edited
Loading

https://signal.org/blog/phone-number-privacy-usernames/

https://discuss.privacyguides.net/t/signal-usernames-are-available-today/16995

  • Please check this box to confirm you have disclosed any relevant conflicts of interest in your post.
  • Please check this box to confirm your agreement to grant Privacy Guides a perpetual, worldwide, non-exclusive, transferable, royalty-free, irrevocable license with the right to sublicense such rights through multiple tiers of sublicensees, to reproduce, modify, display, perform, relicense, and distribute your contribution as part of our project.
  • Please check this box to confirm you are the sole author of this work, or that any additional authors will also reply to this PR on GitHub confirming their agreement to these terms.

@netlify
Copy link

netlify bot commented Mar 8, 2023 •
edited
Loading

✅ Deploy Preview for privacyguides ready!

Name Link
🔨 Latest commit a890fc4
🔍 Latest deploy log https://app.netlify.com/sites/privacyguides/deploys/65d5306fd95ee000083a42b0
😎 Deploy Preview https://deploy-preview-2079.preview.privacyguides.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 4 paths audited
Performance: 73 (🔴 down 13 from production)
Accessibility: 91 (🔴 down 1 from production)
Best Practices: 98 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jonaharagon jonaharagon mentioned this pull request Mar 10, 2023
Closed
3 tasks
@jonaharagon jonaharagon force-pushed the main branch 2 times, most recently from a45aaa2 to 4c805da Compare April 6, 2023 20:53
jonaharagon added a commit that referenced this pull request Oct 24, 2023
@jonaharagon
Add Signal username information (#2079)
32c612e
@jonaharagon jonaharagon force-pushed the jonaharagon/signal-usernames branch from 61181f8 to 32c612e Compare October 24, 2023 06:23
jonaharagon added a commit that referenced this pull request Oct 24, 2023
@jonaharagon
Add Signal username information (#2079)
08bcdb2
@jonaharagon jonaharagon force-pushed the jonaharagon/signal-usernames branch from 32c612e to 08bcdb2 Compare October 24, 2023 06:27
jonaharagon added a commit that referenced this pull request Nov 9, 2023
@jonaharagon
Add Signal username information (#2079)
41dd220
@jonaharagon jonaharagon force-pushed the jonaharagon/signal-usernames branch from 08bcdb2 to 41dd220 Compare November 9, 2023 00:48
@jonaharagon jonaharagon marked this pull request as ready for review February 20, 2024 18:24
jonaharagon added a commit that referenced this pull request Feb 20, 2024
@jonaharagon
Add Signal username information (#2079)
dca2c65
@jonaharagon jonaharagon force-pushed the jonaharagon/signal-usernames branch from 41dd220 to dca2c65 Compare February 20, 2024 18:26
blacklight447
blacklight447 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@blacklight447 blacklight447 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets goooooo.

freddy-m
freddy-m approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@freddy-m freddy-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been waiting for so long - feels very good to approve!

jonaharagon added a commit that referenced this pull request Feb 20, 2024
@jonaharagon
Add Signal username information (#2079)
3aef786
@jonaharagon jonaharagon force-pushed the jonaharagon/signal-usernames branch from dca2c65 to 3aef786 Compare February 20, 2024 23:01
jonaharagon added a commit that referenced this pull request Feb 20, 2024
@jonaharagon
Add Signal username information (#2079)
5a7499e
@jonaharagon jonaharagon force-pushed the jonaharagon/signal-usernames branch from 3aef786 to 5a7499e Compare February 20, 2024 23:03
@jonaharagon
Add Signal username information (#2079)
a890fc4 
Signed-off-by: Freddy <[email protected]>
Signed-off-by: blacklight447 <[email protected]>
@jonaharagon jonaharagon force-pushed the jonaharagon/signal-usernames branch from 5a7499e to a890fc4 Compare February 20, 2024 23:06
@jonaharagon jonaharagon merged commit a890fc4 into main Feb 20, 2024
6 of 7 checks passed
@jonaharagon jonaharagon deleted the jonaharagon/signal-usernames branch February 20, 2024 23:06
@privacyguides-bot
Copy link
Collaborator

This pull request has been mentioned on Privacy Guides. There might be relevant details there:

https://discuss.privacyguides.net/t/v3-21/17131/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacklight447 blacklight447 blacklight447 approved these changes

@freddy-m freddy-m freddy-m approved these changes

@dngray dngray Awaiting requested review from dngray

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonaharagon @privacyguides-bot @freddy-m @blacklight447