-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
…ns to be used with the ConstrDecomp
…re structured way of storing common subexpressions
…on for common exprs
Why is not passing the tests? |
@rutefig sorry, there where it says An object that implements a trait should be passed to return the score. When that is done, let me know, to review again |
Just formatting, I will fix it when it would be ready for review |
@leolara Can you review again pls? |
@rutefig we need a default implementation of the scorer following this rules as explained before:
|
The scorer is good, now I need to review the rest. I have not checked the tests, but make sure they are comprehensive and check corner cases. |
} | ||
|
||
impl<F, V> Default for ConstrDecomp<F, V> { | ||
impl<F, V: Debug, M> ConstrDecomp<F, V, M> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean what is the method get_auto_signal for?
…order for the expressions optimised
No description provided.