feat: introduce mainnet profile #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
requested review from
shaspitz and
aloknerurkar
and removed request for
shaspitz
2 tasks
shaspitz
approved these changes
Dec 24, 2024
| @@ -148,8 +148,10 @@ job "{{ job.name }}" { | |||
| --directory /usr/local \ | |||
| --strip-components=1 | |||
|
|
|||
| find local/contracts -type f -name "._*.sol" -exec rm -f {} + | |||
There was a problem hiding this comment.
Odd that we need this line, but it shouldn't hurt anything
|
I'll set this PR to close #338 |
| - *mev_commit_geth_member_node_job | ||
| - *contracts_deployer_job | ||
| - *mev_commit_bridge_job | ||
| - *mev_commit_dashboard_job |
There was a problem hiding this comment.
I think I forgot to add a rule in our nginx for the dashboard. We can call it dashboard.mev-commit.xyz maybe. It uses a different port. If possible add this as well.
aloknerurkar
approved these changes
Dec 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Introduces mainnet profile.
Checklist before requesting a review