fix(libp2p): standardize protocol ID across all protocols #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kant777
force-pushed
the
fix/protocolID
branch
2 times, most recently
from
bec031c to
d9a2704
Compare
aloknerurkar
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
You will need to update the PR title in conventional commit format, otherwise it may complain when you merge.
fix: protocol ID for SetStreamHandlerMatch
Also please run the devnet setup once before merging. I think devnet setup to ensure connectivity and bids going through should be enough validation.
mrekucci
changed the title
kant777
force-pushed
the
fix/protocolID
branch
5 times, most recently
from
95ab7f7 to
fc258e1
Compare
mrekucci
changed the title
mrekucci
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mev-commitvendor as part of the protocol IDv0.35.3