chore: standardize solidity version to 0.8.20 across repo #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did we decide to use 0.8.20 and not 0.8.26, for example? |
If I remember correctly it first had to do with matching the version of one of our open-zeppelin dependancies. At this point 0.8.20 is just what we've tested the most and designed around. So no need to upgrade until a future solidity version has a critical feature or fix that affects us |
mrekucci
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://swcregistry.io/docs/SWC-103/. This branch looks good in devnet setup and should effectively be a refactor. Ie. we've been using 0.8.20 already but this PR makes it explicit everywhere