Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Improve example for builder RPC client #55

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Conversation

aloknerurkar
Copy link
Contributor

No description provided.

@ckartik
Copy link
Contributor

ckartik commented Oct 13, 2023

@iowar worked on the original example, so will want to get his input as well.

@iowar
Copy link
Collaborator

iowar commented Oct 13, 2023

This example was tested locally using the builder API instead of the noopProcessor, and a successful bid transaction took place.
but I think grpc.WithInsecure is deprecated

@aloknerurkar
Copy link
Contributor Author

This example was tested locally using the builder API instead of the noopProcessor, and a successful bid transaction took place. but I think grpc.WithInsecure is deprecated

During actual deployment I think its easier to manage the TLS through nginx. So the client has to do some additional work. But for the purpose of the example the insecure option should be okay I think.

@aloknerurkar aloknerurkar merged commit bcddf8e into main Oct 13, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants