This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Iowar/protobuf.0 #33
Merged
Iowar/protobuf.0 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aloknerurkar
reviewed
Oct 3, 2023
pkg/p2p/protobuf/protobuf.go
Outdated
| "google.golang.org/protobuf/proto" | ||
| ) | ||
|
|
||
| type IProtobuf interface { |
There was a problem hiding this comment.
Lets call this Encoding/Encoder
When users import this package they will have protobuf as pkg name already. So protobuf.Encoder/Encoding makes more sense.
pkg/p2p/protobuf/protobuf.go
Outdated
| out p2p.Stream | ||
| } | ||
|
|
||
| const delimitedReaderMaxSize = 1024 * 1024 //nolint:unused |
pkg/p2p/protobuf/protobuf.go
Outdated
|
|
||
| const delimitedReaderMaxSize = 1024 * 1024 //nolint:unused | ||
|
|
||
| func NewReaderWriter(in p2p.Stream, out p2p.Stream) IProtobuf { |
There was a problem hiding this comment.
So the p2p.Stream is already duplex. It has Read and Write functions. So I dont think we need to pass separately.
Take a look at the test in msgpack. You can create two separate reader/writer and pass the duplex stream to test.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.