fix: lint

primev · Jan 12, 2024 · fff2f6e · fff2f6e
1 parent 231e6e2
commit fff2f6e
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 14 deletions.
diff --git a/pkg/apiserver/apiserver.go b/pkg/apiserver/apiserver.go
@@ -99,7 +99,7 @@ func (a *Service) registerStatsEndpoints() {
 
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		w.Write(resp)
+		_, _ = w.Write(resp)
 	})
 
 	a.router.HandleFunc("/stats", func(w http.ResponseWriter, r *http.Request) {
@@ -119,7 +119,7 @@ func (a *Service) registerStatsEndpoints() {
 
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		w.Write(resp)
+		_, _ = w.Write(resp)
 	})
 }
 

diff --git a/pkg/node/node.go b/pkg/node/node.go
@@ -98,12 +98,14 @@ func NewNode(opts *Options) (*Node, error) {
 	)
 	if err != nil {
 		log.Fatal().Err(err).Msg("failed to instantiate preconf contract")
+		cancel()
 		return nil, err
 	}
 
 	oracleContract, err := rollupclient.NewOracle(opts.OracleContractAddr, settlementClient)
 	if err != nil {
 		log.Fatal().Err(err).Msg("failed to instantiate oracle contract")
+		cancel()
 		return nil, err
 	}
 
@@ -121,6 +123,7 @@ func NewNode(opts *Options) (*Node, error) {
 			)
 			if err != nil {
 				log.Fatal().Err(err).Msg("failed to set builder mapping")
+				cancel()
 				return nil, err
 			}
 		}

diff --git a/pkg/settler/settler.go b/pkg/settler/settler.go
@@ -183,6 +183,7 @@ func (s *Settler) Start(ctx context.Context) <-chan struct{} {
 		for {
 			select {
 			case <-ctx.Done():
+				unsub()
 				return
 			case settlement, more := <-settlementChan:
 				if !more {

diff --git a/pkg/updater/updater.go b/pkg/updater/updater.go
@@ -87,6 +87,7 @@ func (u *Updater) Start(ctx context.Context) <-chan struct{} {
 		for {
 			select {
 			case <-ctx.Done():
+				unsub()
 				return
 			case winner, more := <-winnerChan:
 				if !more {

diff --git a/pkg/updater/updater_test.go b/pkg/updater/updater_test.go
@@ -120,19 +120,17 @@ func TestUpdater(t *testing.T) {
 		if count == 10 {
 			break
 		}
-		select {
-		case settlement := <-testWinnerRegister.settlements:
-			if settlement.blockNum != 5 {
-				t.Fatal("wrong block number")
-			}
-			if settlement.builder != "test" {
-				t.Fatal("wrong builder")
-			}
-			if settlement.isSlash {
-				t.Fatal("should not be slash")
-			}
-			count++
+		settlement := <-testWinnerRegister.settlements
+		if settlement.blockNum != 5 {
+			t.Fatal("wrong block number")
 		}
+		if settlement.builder != "test" {
+			t.Fatal("wrong builder")
+		}
+		if settlement.isSlash {
+			t.Fatal("should not be slash")
+		}
+		count++
 	}
 
 	select {