-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a section for bundles #61
base: main
Are you sure you want to change the base?
Conversation
need to understand the interactivity of this with eth_sendBundle. since you can express which txs are allowed to revert in your mev bundle to the builder, I'm unsure if this is needed revertingTxHashes, // [String], list of tx hashes that are allowed to revert or be discarded it's unclear whether all mev-commit bids presume atomic bundles? if I have 3 txs in my bid, but have said it's ok for 1 to revert in the bundle, what happens? |
@ckartik need you to address the comments to merge this PR |
@Dogandi we do assume atomic bundles. It's not hard for us to start allowing discarding of some of these transactions. We have two options we can go for:
|
@ckartik it sounds like option 1 would be prefferred esp. being in line with execution preconfs. However we need to fully think through how this bid is additive with the eth_bundle command to block builders: are we introducing redundancy? we need to make this expression efficient and compatible with current builder expression. is this feasible? |
Sounds good, in the meantime I've started to work on Option 1. Here is the first PR of the two primary ones to build this feature set. |
what's the status with this PR? @ckartik, let's merge if the feature is out |
No description provided.