Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a section for bundles #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ckartik
Copy link
Contributor

@ckartik ckartik commented May 15, 2024

No description provided.

@techgangboss
Copy link
Contributor

need to understand the interactivity of this with eth_sendBundle. since you can express which txs are allowed to revert in your mev bundle to the builder, I'm unsure if this is needed

revertingTxHashes, // [String], list of tx hashes that are allowed to revert or be discarded

it's unclear whether all mev-commit bids presume atomic bundles? if I have 3 txs in my bid, but have said it's ok for 1 to revert in the bundle, what happens?

@Dogandi
Copy link
Collaborator

Dogandi commented Jun 10, 2024

@ckartik need you to address the comments to merge this PR

@ckartik
Copy link
Contributor Author

ckartik commented Jun 17, 2024

@Dogandi we do assume atomic bundles. It's not hard for us to start allowing discarding of some of these transactions. We have two options we can go for:

  1. Keep these arrays as atomic bundles and add new fields to specify which transactions can revert. Update the oracle to decision on this flow.
  2. Remove the atomic bundle requirement all together, making tx_hashes array just a arbitrary non-positional array of transactions that should be included.

@techgangboss
Copy link
Contributor

@ckartik it sounds like option 1 would be prefferred esp. being in line with execution preconfs. However we need to fully think through how this bid is additive with the eth_bundle command to block builders:

image

are we introducing redundancy? we need to make this expression efficient and compatible with current builder expression. is this feasible?

@ckartik
Copy link
Contributor Author

ckartik commented Jun 20, 2024

Sounds good, in the meantime I've started to work on Option 1.

Here is the first PR of the two primary ones to build this feature set.

@techgangboss
Copy link
Contributor

techgangboss commented Aug 15, 2024

what's the status with this PR? @ckartik, let's merge if the feature is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants