Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass environment variables down through supervisord #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DASPRiD
Copy link

@DASPRiD DASPRiD commented May 8, 2024

#61 allowed setting GUNICORN_BIND_ADDR, but environment variables were never passed down through sudo into supervisord, so this had no effect.

This PR fixes that by passing all environment variables down to supervisord. This additionally allows to completely skip a config file and configure pretalx entirely through env variables instead.

For the time being until this is merged and released I have published a hotfixed version myself:
https://hub.docker.com/repository/docker/dasprid/pretalx-standalone/general

@almereyda
Copy link
Collaborator

almereyda commented May 9, 2024

Just noting that due to multiple issues with this repository this week I was working on an extensive production-ready rewrite of the environment to remove the Supervisor altogether.

I am in process of commiting the changes and documenting their rationale, in so we can have a community-wide conversation about where to take this repository together.

main...allmende:pretalx-docker:main

Please look out for a related Pull Request within the day.

@almereyda
Copy link
Collaborator

Please find

for review and feedback.

@rixx
Copy link
Member

rixx commented May 15, 2024

@DASPRiD thank you for taking the time to look into this! Let's figure out how #64 is going to work out, and in case it's not getting merged, we can revisit this PR, I'd say?

@DASPRiD
Copy link
Author

DASPRiD commented May 15, 2024

Sounds good to me.

TriplEight added a commit to TriplEight/pretalx-docker that referenced this pull request Oct 3, 2024
TriplEight added a commit to TriplEight/pretalx-docker that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants