Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give Prestissimo team the ability to merge CI updates #24375

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

tdcmeehan
Copy link
Contributor

Description

C++ testing configurations should be merged by the C++ codeowners.

Motivation and Context

Let C++ developers manage CI without a general committer approval.

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 16, 2025
@prestodb-ci prestodb-ci requested review from a team, psnv03 and pramodsatya and removed request for a team January 16, 2025 14:56
@tdcmeehan tdcmeehan marked this pull request as ready for review January 16, 2025 14:57
@tdcmeehan tdcmeehan requested a review from a team as a code owner January 16, 2025 14:57
CODEOWNERS Outdated
@@ -112,6 +112,7 @@ CODEOWNERS @prestodb/team-tsc
#####################################################################
# Prestissimo module
/presto-native-execution @prestodb/team-velox
/.github/workflows/prestocpp-* @prestodb/team-velox
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

include prestodb/committers too. Better to be more expansive with this one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@tdcmeehan tdcmeehan force-pushed the tdcmeehan-patch-14 branch 2 times, most recently from 9a5fc88 to 1b2671b Compare January 16, 2025 15:21
@tdcmeehan tdcmeehan merged commit 628e36c into master Jan 16, 2025
52 checks passed
@tdcmeehan tdcmeehan deleted the tdcmeehan-patch-14 branch January 16, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants