-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webpack file size warnings on entrypoints #24374
Draft
unidevel
wants to merge
2
commits into
prestodb:master
Choose a base branch
from
unidevel:fix_size_warning
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
prestodb-ci
requested review from
a team,
bibith4 and
pratyakshsharma
and removed request for
a team
January 17, 2025 15:06
unidevel
changed the title
fix webpack file size warnings(>244k) on entrypoints
Fix webpack file size warnings(>244k) on entrypoints
Jan 17, 2025
unidevel
changed the title
Fix webpack file size warnings(>244k) on entrypoints
Fix webpack file size warnings on entrypoints
Jan 17, 2025
After this PR applied,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As in issue #22759, there are multiple wanrings about file size like this
Motivation and Context
Impact
Introduce react dynamic import for code splitting
Also added the webpack
splitChunks
configuration to split large dependenciesTest Plan
Require function testing on presto-ui
Contributor checklist
Release Notes