[MongoDB] add TLS CA File steps to docs #24352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apidcloud
requested review from
steveburnett,
elharo and
a team
as code owners
steveburnett
requested changes
Jan 13, 2025
There was a problem hiding this comment.
Thank you for the new documentation! I think your steps might be better off with better visibility so I made suggestions of how to move them out of the property definition, and into a new heading in this page that you would link to. Let me know what you think!
|
Suggest changes to release note entry as follows: |
|
Thanks for the review and suggestions. I think it looks a lot better now |
steveburnett
requested changes
Jan 13, 2025
steveburnett
requested changes
Jan 13, 2025
steveburnett
approved these changes
Jan 13, 2025
Apidcloud
force-pushed
the
docs/add-info-about-mongo-tls-ca
branch
from
a9ed390 to
fdac83f
Compare
Apidcloud
changed the title
|
LGTM. @Apidcloud in the future, please squash commits per our development guidelines. Thanks! |
|
Thanks, @tdcmeehan. I was going to ask whether GitHub supports squashing upon merging, like Gitlab. Thanks for letting me know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Noticed there's no documentation on how to really connect Presto to a MongoDB Cluster, as it usually requires access to a TLS Certificate.
Motivation and Context
When I was setting up Presto, I had to add the TLS CA File we have from Digital Ocean to connect to the MongoDB Cluster. I noticed the docs are missing steps for such thing, despite being a very common requirement. This adds that missing information, step by step.
Release Notes