Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support BigInt in the QueryResult component #24336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yhwang
Copy link
Member

@yhwang yhwang commented Jan 8, 2025

Description

Check the data type of a column and pass different selector functions. BigInt data type needs to explicitly use the toString() function to print out the value.

Motivation and Context

fix issue: #23821

Impact

Presto UI can display BigInt data in supported browsers.

Test Plan

Verify the BigInt data type in the supported browser: Chrome
and also verify it doesn't break unsupported browser: Firefox (at this moment, firefox hasn't supported it yet)

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Add support for ``BigInt`` data type in the SQL Client on Presto UI on supported browsers. See
`compatibility <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse#browser_compatibility>`_ for the supported browsers. :pr:`24336`

Check the data type of a row and pass different selector functions.
BigInt data type needs to explicitly use the `toString()` function to
print out the value.

Signed-off-by: Yihong Wang <[email protected]>
@yhwang yhwang requested a review from a team as a code owner January 8, 2025 19:49
@yhwang yhwang requested a review from presto-oss January 8, 2025 19:49
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Jan 8, 2025
@prestodb-ci prestodb-ci requested review from a team, anandamideShakyan and sh-shamsan and removed request for a team January 8, 2025 19:49
@tdcmeehan tdcmeehan self-assigned this Jan 8, 2025
@yhwang
Copy link
Member Author

yhwang commented Jan 8, 2025

Attached the screenshot that I verified on Chrome(a supported browser):
Screenshot 2025-01-08 at 11 54 04 AM

On an unsupported browser: Firefox, the BigInt data loses the precision but it doesn't break any UI/feature:
image

@steveburnett
Copy link
Contributor

Nit suggestions for the release note entry to follow the phrasing in the Order of Changes in the Release Notes Guidelines.

== RELEASE NOTES ==

General Changes
* Add support for ``BigInt`` data type in the SQL Client on Presto UI on supported browsers. See
`compatibility <https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse#browser_compatibility>`_ for the supported browsers. :pr:`24336`

@yhwang
Copy link
Member Author

yhwang commented Jan 8, 2025

Thanks for the comment @steveburnett. Updated the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants