Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Java 17 upgrade w/ Java 8 bytecode #23803

Draft
wants to merge 27 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
60c40a2
Java 17 Upgrade
imjalpreet Oct 10, 2024
6da5379
update to use jitpack and auto-detect jdk profiles
ZacBlanco Oct 10, 2024
c103306
update action ci for java 17
ZacBlanco Oct 10, 2024
ab75c69
Add JVM add-opens args for testing
ZacBlanco Oct 10, 2024
3937e9b
Add JVM add-opens to fix cassandra-integration-smoke-test
imjalpreet Oct 14, 2024
14e0215
additional add-opens
ZacBlanco Oct 14, 2024
313a7cd
Change surefire configs to use airbase properties
ZacBlanco Oct 14, 2024
021fd7c
Disable KllSketch memory test for strings
ZacBlanco Oct 14, 2024
a723cd5
Add-opens for presto-spark-base
ZacBlanco Oct 14, 2024
7591c29
Use matrix to test java 8 and 17 with GH actions
ZacBlanco Oct 15, 2024
e22d680
disable fail-fast on GH Actions workflows
ZacBlanco Oct 15, 2024
0271725
Update base image for Presto
aaneja Oct 21, 2024
9b5aa6a
Run product tests only on JDK 17
aaneja Oct 22, 2024
f254534
Tweaks to JVM configs for multinode setup
aaneja Oct 23, 2024
8e09e1a
WIP upgrade tempto deps
aaneja Oct 17, 2024
808150d
Fix rebase issues
aaneja Nov 27, 2024
6981727
Switch product-tests back to JDK8 compat
aaneja Nov 27, 2024
f915e7c
generate-service-descriptor for presto-native-sidecar-plugin
imjalpreet Nov 20, 2024
2b313db
add-opens for presto-parquet
imjalpreet Dec 3, 2024
a9fb695
Force maven central to take precedence (#24204)
ZacBlanco Dec 5, 2024
abbef41
Product tests fix for kerberized tests
aaneja Dec 19, 2024
7e0ffbc
Product tests fix for more tests
aaneja Dec 20, 2024
8435a73
Force MySQL connection to use TLSv1.2
aaneja Jan 7, 2025
1adafde
Upgrade kafka to 3.9.0
ZacBlanco Jan 7, 2025
4fcd003
use apache/kafka image in product-tests
ZacBlanco Jan 9, 2025
c503685
Skip incompatible accumulo tests on Java 17
ZacBlanco Jan 10, 2025
7eefdc5
Use airbase 104 from central
ZacBlanco Jan 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 0 additions & 42 deletions .github/workflows/cleanup.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: 17
- name: Install LaTeX dependencies
run: |
sudo apt-get update
Expand Down
16 changes: 12 additions & 4 deletions .github/workflows/hive-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,16 @@ jobs:
- '!presto-docs/**'

hive-tests:
strategy:
fail-fast: false
matrix:
java: [ 8, 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-hive-tests-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-hive-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -45,7 +49,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down Expand Up @@ -83,12 +87,16 @@ jobs:
fi

hive-dockerized-tests:
strategy:
fail-fast: false
matrix:
java: [ 8, 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 20
concurrency:
group: ${{ github.workflow }}-hive-dockerized-tests-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-hive-dockerized-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -97,7 +105,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/kudu.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ jobs:
codechange:
- '!presto-docs/**'
kudu:
strategy:
fail-fast: false
matrix:
java: [ 8, 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-kudu-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-kudu-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -43,7 +47,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/maven-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,14 @@ env:

jobs:
maven-checks:
strategy:
fail-fast: false
matrix:
java: [ 8, 17 ]
runs-on: ubuntu-latest
timeout-minutes: 45
concurrency:
group: ${{ github.workflow }}-maven-checks-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-maven-checks-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -29,7 +33,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/product-tests-basic-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ jobs:
codechange:
- '!presto-docs/**'
product-tests-basic-environment:
strategy:
fail-fast: false
matrix:
java: [ 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-product-tests-basic-environment-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-product-tests-basic-environment-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -49,7 +53,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
16 changes: 12 additions & 4 deletions .github/workflows/product-tests-specific-environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,16 @@ jobs:
codechange:
- '!presto-docs/**'
product-tests-specific-environment1:
strategy:
fail-fast: false
matrix:
java: [ 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-product-tests-specific-environment1-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-product-tests-specific-environment1-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -49,7 +53,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down Expand Up @@ -80,12 +84,16 @@ jobs:
run: presto-product-tests/bin/run_on_docker.sh multinode-tls-kerberos -g cli,group-by,join,tls

product-tests-specific-environment2:
strategy:
fail-fast: false
matrix:
java: [ 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-product-tests-specific-environment2-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-product-tests-specific-environment2-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- name: Free Disk Space
Expand All @@ -100,7 +108,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/singlestore-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,17 @@ jobs:
codechange:
- '!presto-docs/**'
singlestore-dockerized-tests:
strategy:
fail-fast: false
matrix:
java: [ 8, 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'

timeout-minutes: 30
concurrency:
group: ${{ github.workflow }}-singlestore-dockerized-tests-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-singlestore-dockerized-tests-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -56,7 +60,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/spark-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,16 @@ jobs:
codechange:
- '!presto-docs/**'
spark-integration:
strategy:
fail-fast: false
matrix:
java: [ 8, 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-spark-integration-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-spark-integration-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -44,7 +48,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/test-other-modules.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,16 @@ jobs:
codechange:
- '!presto-docs/**'
test-other-modules:
strategy:
fail-fast: false
matrix:
java: [ 8, 17 ]
runs-on: ubuntu-latest
needs: changes
if: needs.changes.outputs.codechange == 'true'
timeout-minutes: 60
concurrency:
group: ${{ github.workflow }}-test-other-modules-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-test-other-modules-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -44,7 +48,7 @@ jobs:
- uses: actions/setup-java@v2
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
id: cache-maven
uses: actions/cache@v2
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
strategy:
fail-fast: false
matrix:
java: [8, 17]
modules:
- ":presto-tests -P presto-tests-execution-memory"
- ":presto-tests -P presto-tests-general"
Expand Down Expand Up @@ -68,7 +69,7 @@ jobs:
- ":presto-iceberg"
timeout-minutes: 80
concurrency:
group: ${{ github.workflow }}-test-${{ matrix.modules }}-${{ github.event.pull_request.number }}
group: ${{ github.workflow }}-test-${{ matrix.modules }}-${{ github.event.pull_request.number }}-${{ matrix.java }}
cancel-in-progress: true
steps:
- uses: actions/checkout@v4
Expand All @@ -79,7 +80,7 @@ jobs:
if: needs.changes.outputs.codechange == 'true'
with:
distribution: 'temurin'
java-version: 8
java-version: ${{ matrix.java }}
- name: Cache local Maven repository
if: needs.changes.outputs.codechange == 'true'
id: cache-maven
Expand Down
2 changes: 1 addition & 1 deletion .mvn/jvm.config
Original file line number Diff line number Diff line change
@@ -1 +1 @@
-Xmx8192m
-Xmx8192m
Loading
Loading