Introducing ClientRequestFilter.java: A New Plugin for Merging Additional Headers into Client Requests in the Authentication Filter #23380

SthuthiGhosh9400 · 2024-08-05T12:04:17Z

Description

A new interface, ClientRequestFilter.java, has been introduced in the Presto SPI to customize the headers used by the Presto runtime to process queries. Some example use cases include customized authentication workflows, or enriching query attributes such as the query source.
One key use case is setting extra credentials in the request headers.

Motivation and Context

#23997

Impact

This feature enables the merging of headers of any type, offering a versatile solution for header management.

Test Plan

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==
General Changes
* Add ``ClientRequestFilter.java`` interface in Presto-spi. :pr:`23380`
* Improve Request Headers in the Authentication Filter Class. :pr:`23380`

tdcmeehan

This PR needs some test cases.

steveburnett · 2024-08-26T14:31:07Z

Nit rephrasing of release note entries following the Order of changes in the Release Notes Guidelines.

== RELEASE NOTES ==

General Changes

* Add  `RequestModifier.java` interface in Presto-spi :pr:`23380`
* Improve Request Headers in the Authentication Filter Class :pr:`23380`

SthuthiGhosh9400 · 2024-08-30T04:34:18Z

@tdcmeehan

I have added a test case to verify setting values in the request header and committed it.
Could you have a check and confirm ?
Thanks.

presto-main/pom.xml

tdcmeehan · 2024-09-05T19:38:53Z

presto-main/src/test/java/com/facebook/presto/TestRequestHeaderModifier.java

+        assertEquals("CustomValue", wrappedRequest.getHeader("X-Custom-Header"));
+    }
+
+    abstract static class HttpServletRequestAdapter


There's already a MockHttpServletRequest, can you use that?

@tdcmeehan
I have refactored the code to use MockHttpServletRequest. Could you check it?
Thanks.

tdcmeehan · 2024-09-06T14:06:40Z

While we don't use Mockito, the stubs in the test are a little out of control. We need to reduce the size of this simple test. I have a couple of suggestions that you can research to make the testing simpler.

Can you look at TestHttpRemoteTask and examine how they implemented an in-memory endpoint for the purposes of testing? Perhaps you can build something similar.
TestingPrestoServer has all sorts of helper methods to retrieve individual classes from Presto. Perhaps you can add a new getter to retrieve the RequestModifierManager, register a simple new request modifier that just adds a dummy header, and make a client call that proves the header is added.

SthuthiGhosh9400 · 2024-09-08T13:22:51Z

TestingPrestoServer has all sorts of helper methods to retrieve individual classes from Presto. Perhaps you can add a new getter to retrieve the RequestModifierManager, register a simple new request modifier that just adds a dummy header, and make a client call that proves the header is added.

@tdcmeehan
I have attempted to improve the test case based on the suggestion. Could you have a check?
Thanks.

tdcmeehan · 2024-09-09T13:34:40Z

presto-main/src/main/java/com/facebook/presto/server/testing/TestingPrestoServer.java

@@ -825,4 +830,25 @@ private static int driftServerPort(DriftServer server)
    {
        return ((DriftNettyServerTransport) server.getServerTransport()).getPort();
    }
+
+    public RequestModifierManager getRequestModifierManager()


Please, just add a method to return the RequestModifierManager, and let users inject whatever custom modifier they wish.

tdcmeehan · 2024-09-09T13:36:44Z

presto-main/src/main/java/com/facebook/presto/RequestModifierManager.java

+
+public class RequestModifierManager
+{
+    private final List<RequestModifier> requestModifiers;


This needs to be thread safe. I recommend using a CopyOnWriteArrayList.

tdcmeehan · 2024-09-09T14:08:20Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

            // authentication succeeded
-            nextFilter.doFilter(withPrincipal(request, principal), response);
+            CustomHttpServletRequestWrapper wrappedRequest = withPrincipal(request, principal);


Instead of modifying the authentication filter, this should just go in its own filter that is applied after the authentication filter.

tdcmeehan · 2024-09-09T14:08:37Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+            this.customHeaders = new HashMap<>();
+        }
+
+        public void addHeader(String name, String value)


presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

tdcmeehan · 2024-09-09T14:09:59Z

presto-spi/src/main/java/com/facebook/presto/spi/RequestModifier.java

+import java.util.Map;
+import java.util.Optional;
+
+public interface RequestModifier


Let's call this something more descriptive, such as ClientRequestFilter.

SthuthiGhosh9400 · 2024-09-10T04:38:48Z

@tdcmeehan
I have incorporated the review comments. Could you please verify them?
Thanks.

tdcmeehan · 2024-09-10T12:57:00Z

presto-main/src/main/java/com/facebook/presto/ClientRequestFilterManager.java

+
+public class ClientRequestFilterManager
+{
+    private final CopyOnWriteArrayList<ClientRequestFilter> clientRequestFilters;


Suggested change

private final CopyOnWriteArrayList<ClientRequestFilter> clientRequestFilters;

private final List<ClientRequestFilter> clientRequestFilters;

tdcmeehan · 2024-09-10T12:57:21Z

presto-main/src/main/java/com/facebook/presto/ClientRequestFilterManager.java

+    private final CopyOnWriteArrayList<ClientRequestFilter> clientRequestFilters;
+    public ClientRequestFilterManager()
+    {
+        this.clientRequestFilters = new CopyOnWriteArrayList<>();
+    }


Suggested change

private final CopyOnWriteArrayList<ClientRequestFilter> clientRequestFilters;

public ClientRequestFilterManager()

{

this.clientRequestFilters = new CopyOnWriteArrayList<>();

}

private final List<ClientRequestFilter> clientRequestFilters = new CopyOnWriteArrayList<>();

tdcmeehan · 2024-09-10T12:57:50Z

presto-main/src/main/java/com/facebook/presto/ClientRequestFilterManager.java

+
+    public List<ClientRequestFilter> getClientRequestFilters()
+    {
+        return Collections.unmodifiableList(clientRequestFilters);


Suggested change

return Collections.unmodifiableList(clientRequestFilters);

return ImmutableList.copyOf(clientRequestFilters);

tdcmeehan · 2024-09-10T13:09:42Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+                    extraHeaderValueMap.ifPresent(map -> {
+                        for (Map.Entry<String, String> extraHeaderEntry : map.entrySet()) {
+                            if (request.getHeader(extraHeaderEntry.getKey()) == null) {
+                                extraHeadersMap.putIfAbsent(extraHeaderEntry.getKey(), extraHeaderEntry.getValue());


I don't think we should silently not put the header if there's an existing header. I think we should consider the following:

The SPI contract mandates that any potential header is known upfront.

The runtime will validate that the headers that are requested to be modified match with what is actually returned.

There is a blocklist of headers that the plugin should not modify (such as query ID).

The runtime will validate that all registered filters only return a disjoint set of headers being added. If there is a conflict, this is a fatal error that will require an administrator to fix (but un-registering one of these plugins).

If there is a conflict here, then an exception is thrown.

@tdcmeehan
I have gone through your comments and added a few validations in the current implementation. I can verify that with you. However, I have to know about the headers in the blocklist that should not be modified.
Could you help?

Let's start with the query ID, trace ID and transaction ID in PrestoHeaders.java.

I have incorporated the changes mentioned in your comment. Could you please review them and share your suggestions?

tdcmeehan · 2024-09-10T13:10:12Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+        private final Map<String, String> customHeaders;
+
+        public CustomHttpServletRequestWrapper(HttpServletRequest request)
+        {
+            super(request);
+            this.customHeaders = new ConcurrentHashMap<>();
+        }


Suggested change

private final Map<String, String> customHeaders;

public CustomHttpServletRequestWrapper(HttpServletRequest request)

{

super(request);

this.customHeaders = new ConcurrentHashMap<>();

}

private final Map<String, String> customHeaders = new ConcurrentHashMap<>();

tdcmeehan

Some feedback is still unadressed.

tdcmeehan · 2024-09-25T18:06:15Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+                        for (Map.Entry<String, String> extraHeaderEntry : map.entrySet()) {
+                            String headerKey = extraHeaderEntry.getKey();
+                            if (headersBlockList.contains(headerKey)) {
+                                throw new RuntimeException("Modification attempt detected: The header " + headerKey + " is present in the blocked headers list.");


Please throw a PrestoException and introduce a new error code for this. It should be a system error.

tdcmeehan · 2024-09-25T18:06:34Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+            while (originalHeaderNames.hasMoreElements()) {
+                headerNames.add(originalHeaderNames.nextElement());
+            }
+            return Collections.enumeration(headerNames);


Please use Immutable collections.

SthuthiGhosh9400 · 2024-09-26T15:27:23Z

Some feedback is still unadressed.

@tdcmeehan Could you help me identify which feedback is still pending? I believe I have addressed feedback items 2, 3, 4, and 5 from the list above.

tdcmeehan · 2024-09-26T15:55:23Z

Some feedback is still unadressed.

@tdcmeehan Could you help me identify which feedback is still pending? I believe I have addressed feedback items 2, 3, 4, and 5 from the list above.

Please scroll up in this PR and examine feedback on the code that is still remaining.

SthuthiGhosh9400 · 2024-09-26T16:20:52Z

Please scroll up in this PR and examine feedback on the code that is still remaining.

Yeah. @tdcmeehan I have incorporated all feedback items now. Kindly review them and share your suggestions?

Thanks.

tdcmeehan · 2024-10-07T19:08:25Z

presto-main/src/test/java/com/facebook/presto/TestClientRequestFilterPlugin.java

+        ClientRequestFilter customModifier = new ClientRequestFilter()
+        {
+            @Override
+            public List<String> getHeaderNames()
+            {
+                return Collections.singletonList("X-Custom-Header");
+            }
+            @Override
+            public <T> Optional<Map<String, String>> getExtraHeaders(T additionalInfo)
+            {
+                Map<String, String> headers = new HashMap<>();
+                headers.put("X-Custom-Header", "CustomValue_1");
+                return Optional.of(headers);
+            }
+        };
+
+        ClientRequestFilter customModifierConflict = new ClientRequestFilter()
+        {
+            @Override
+            public List<String> getHeaderNames()
+            {
+                return Collections.singletonList("X-Custom-Header");
+            }
+            @Override
+            public <T> Optional<Map<String, String>> getExtraHeaders(T additionalInfo)
+            {
+                Map<String, String> headers = new HashMap<>();
+                headers.put("X-Custom-Header", "CustomValue_2");
+                return Optional.of(headers);
+            }


Please reduce duplicate code. Consider an inner helper class.

tdcmeehan · 2024-10-07T19:09:12Z

presto-main/src/test/java/com/facebook/presto/TestClientRequestFilterPlugin.java

+    }
+
+    static class ConcreteHttpServletRequest
+            extends MockHttpServletRequest


Why not modify MockHttpServletRequest directly?

In ConcreteHttpServletRequest, I am storing additional headers in the customHeaders map and overriding the getHeaders method to manage them. This functionality isn't natively provided by MockHttpServletRequest, so extending it makes sense.

Just add a new constructor to MockHttpServletRequest that overrides the headers.

SthuthiGhosh9400 · 2024-10-08T20:06:55Z

@tdcmeehan
I have incorporated the review comments. Kindly review them.
If it looks good, I can squash the commits and edit the commit message according to the guidelines.

tdcmeehan

Please refactor tests to use the code under test.

tdcmeehan · 2024-10-09T14:54:41Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+                        for (Map.Entry<String, String> extraHeaderEntry : map.entrySet()) {
+                            String headerKey = extraHeaderEntry.getKey();
+                            if (headersBlockList.contains(headerKey)) {
+                                throw new PrestoException(HEADER_MODIFICATION_ATTEMPT, "Modification attempt detected: The header " + headerKey + " is present in the blocked headers list.");


Instead of mentioning a "blocked headers list", just list out the headers that are not allowed to be modified.

tdcmeehan · 2024-10-09T14:54:55Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+                                throw new PrestoException(HEADER_MODIFICATION_ATTEMPT, "Modification attempt detected: The header " + headerKey + " is present in the blocked headers list.");
+                            }
+                            if (globallyAddedHeaders.contains(headerKey)) {
+                                throw new RuntimeException("Header conflict detected: " + headerKey + " already added by another filter.");


Do not throw RuntimeException, throw PrestoException.

tdcmeehan · 2024-10-09T14:58:04Z

presto-main/src/test/java/com/facebook/presto/TestClientRequestFilterPlugin.java

+                    for (Map.Entry<String, String> extraHeaderEntry : map.entrySet()) {
+                        String headerKey = extraHeaderEntry.getKey();
+                        if (headersBlockList.contains(headerKey)) {
+                            throw new RuntimeException("Modification attempt detected: The header " + headerKey + " is present in the blocked headers list.");


Why are we duplicating code here? I am very confused about how this test works.

SthuthiGhosh9400 · 2024-10-10T23:26:10Z

@tdcmeehan
I have refactored the test cases and used a separate method for adding headers to the request in the Authentication filter.
Could you review it and share your suggestions?

tdcmeehan · 2024-10-15T14:27:21Z

Please squash commits and ensure the commit format follows our guidelines in contributing.md.

tdcmeehan

Almost there. Please also add documentation for this plugin to https://github.com/prestodb/presto/tree/master/presto-docs/src/main/sphinx/develop

tdcmeehan · 2024-12-12T21:02:47Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+                ClientRequestFilterContext context = new ClientRequestFilterContext(principal);
+                Optional<Map<String, String>> extraHeaderValueMap = requestFilter.getExtraHeaders(context);


Sorry, I realize now that the principal is per request. Context objects typically are used to create the plugin. So please revert this, and just add the principal as a plain old parameter to getExtraHeaders, no need for fancy parameterization.

tdcmeehan · 2024-12-12T21:03:08Z

presto-main/src/main/java/com/facebook/presto/server/security/AuthenticationFilter.java

+        Map<String, String> extraHeadersMap = extraHeadersMapBuilder.build();
+        return new ModifiedHttpServletRequest(request, extraHeadersMapBuilder.build());


Suggested change

Map<String, String> extraHeadersMap = extraHeadersMapBuilder.build();

return new ModifiedHttpServletRequest(request, extraHeadersMapBuilder.build());

return new ModifiedHttpServletRequest(request, extraHeadersMapBuilder.build());

Remove duplicate build.

tdcmeehan · 2024-12-12T21:04:52Z

presto-main/src/test/java/com/facebook/presto/TestClientRequestFilterPlugin.java

+            return new ClientRequestFilter() {
+                @Override
+                public List<String> getHeaderNames()
+                {
+                    return ImmutableList.of(headerName);
+                }
+
+                @Override
+                public Optional<Map<String, String>> getExtraHeaders(ClientRequestFilterContext context)
+                {
+                    return Optional.of(ImmutableMap.of(headerName, headerValue));
+                }
+            };


Make this an inner class.

tdcmeehan · 2024-12-13T14:57:02Z

presto-docs/src/main/sphinx/develop/client-request-filter.rst

+Presto facilitates seamless integration of additional headers into client requests using the 
+Client Request Filter plugin via the AuthenticationFilter class, enabling efficient and dynamic header management.


This sounds AI generated. Please keep the documentation factual and concise. Example, instead of"Efficient and dynamic header management", say, "allowing operators of Presto to customize the headers used for query processing by the Presto runtime." "Presto facilitates the seamless integration of additional headers" is another example. "Seamless" has no meaning in this context.

Just say something like "Presto allows operators to customize the headers used by the Presto runtime to process queries. Some example use cases include customized authentication workflows, or enriching query attributes such as the query source." Please use original wording, think about it, and avoid tools to write this.

tdcmeehan · 2024-12-13T14:57:57Z

presto-docs/src/main/sphinx/develop/client-request-filter.rst

+The ``ClientRequestFilterFactory`` is responsible for creating instances of ``ClientRequestFilter``. It also defines 
+the name of the filter, which is subsequently used as the header name in client requests.


Is this true? The name of the filter is the header name in the client request?

tdcmeehan · 2024-12-13T15:00:37Z

presto-docs/src/main/sphinx/develop/client-request-filter.rst

+
+After installing a plugin that implements ``ClientRequestFilterFactory`` on the coordinator, the ``AuthenticationFilter`` class passes the ``principal`` object to the request filter, which returns the header values as a map.
+
+Presto uses the name of the request filter to determine whether the header is present in the blocklist.


What blocklist? Mention the headers which are not allowed to be overidden. Link to the Java source of headers that may be overidden.

tdcmeehan · 2024-12-16T16:29:16Z

presto-spi/src/main/java/com/facebook/presto/spi/ClientRequestFilter.java

+
+public interface ClientRequestFilter
+{
+    List<String> getHeaderNames();


Suggested change

List<String> getHeaderNames();

Set<String> getExtraHeaderKeys();

tdcmeehan · 2024-12-16T16:31:27Z

presto-spi/src/main/java/com/facebook/presto/spi/ClientRequestFilter.java

+{
+    List<String> getHeaderNames();
+
+    Optional<Map<String, String>> getExtraHeaders(Principal principal);


Can it just return empty map and we don't return optional?

tdcmeehan · 2024-12-16T16:32:17Z

presto-docs/src/main/sphinx/develop/client-request-filter.rst

+``ClientRequestFilter``  interface provides two methods: ``getExtraHeaders()``,
+which returns header values as key-value pairs in a map, and ``getHeaderNames()``, which returns a list of header names used as the header names in client requests.


I imagine getExtraHeaders is used for the runtime to quickly check if it needs to apply a more expensive call to enrich the headers. If so, add this context to the documentation.

tdcmeehan

Just one more thing, otherwise looks good.

tdcmeehan · 2024-12-17T17:39:53Z

presto-main/src/main/java/com/facebook/presto/ClientRequestFilterManager.java

+@ThreadSafe
+public class ClientRequestFilterManager
+{
+    private List<ClientRequestFilterFactory> factories = new CopyOnWriteArrayList<>();


Let's make this a map.

The key of the map should be the name of the factory.

We should not allow duplicate names.

tdcmeehan · 2024-12-17T17:56:53Z

presto-main/src/main/java/com/facebook/presto/ClientRequestFilterManager.java

+        }
+
+        filters = factories.stream()
+                .map(factory -> factory.create(factory.getName()))


This construct is strange. See above comment.

What I meant was, please don't pass in factory.getName() into the create method, there is no need because it can just internally call getName().

SthuthiGhosh9400 · 2024-12-20T05:05:57Z

@tdcmeehan I have made the changes. Could you please take a look?

tdcmeehan · 2024-12-20T15:45:15Z

presto-main/src/main/java/com/facebook/presto/ClientRequestFilterManager.java

+        }
+
+        filters = factories.stream()
+                .map(factory -> factory.create(factory.getName()))


What I meant was, please don't pass in factory.getName() into the create method, there is no need because it can just internally call getName().

steveburnett

Thanks for the doc! A few suggestions.

Also, to have this new doc page be visible in the Developer Guide index page, you must edit presto-docs/src/main/sphinx/develop.rst
and add
develop/client-request-filter.

presto-docs/src/main/sphinx/develop/client-request-filter.rst

SthuthiGhosh9400 · 2025-01-06T04:52:22Z

@steveburnett I have incorporated the changes requested. Thanks.

steveburnett

LGTM! (docs)

Pull updated branch, new local doc build, looks good. Thanks!

SthuthiGhosh9400 · 2025-01-07T07:27:19Z

@tdcmeehan Could you take a look and approve?

tdcmeehan · 2025-01-10T19:59:45Z

Please fix rebase conflicts.

SthuthiGhosh9400 · 2025-01-14T09:10:03Z

@tdcmeehan
I have resolved the conflicts during the rebase. Could you help?

SthuthiGhosh9400 · 2025-01-16T07:06:37Z

If it looks good, can we merge this PR? @tdcmeehan

tdcmeehan · 2025-01-16T15:03:14Z

@SthuthiGhosh9400 the CI is read. Please investigate. If you find it's not related, rebase to rerun the test.

Add ClientRequestFilter.java interface in Presto-spi module. Improve Request Headers in the Authentication Filter Class.

SthuthiGhosh9400 · 2025-01-16T18:53:14Z

@tdcmeehan I reran the test, and it looks good now.

SthuthiGhosh9400 requested a review from a team as a code owner August 5, 2024 12:04

SthuthiGhosh9400 requested a review from presto-oss August 5, 2024 12:04

SthuthiGhosh9400 mentioned this pull request Aug 5, 2024

Introducing RequestModifier.java: A New Plugin for Modifying Request Headers in the Authentication Filter Class #23136

Closed

6 tasks

tdcmeehan self-assigned this Aug 5, 2024

tdcmeehan requested changes Aug 15, 2024

View reviewed changes

tdcmeehan requested changes Aug 30, 2024

View reviewed changes

presto-main/pom.xml Show resolved Hide resolved

tdcmeehan requested changes Sep 5, 2024

View reviewed changes

tdcmeehan requested changes Sep 9, 2024

View reviewed changes

SthuthiGhosh9400 changed the title ~~Introducing RequestModifier.java: A New Plugin for Modifying Request Headers in the Authentication Filter Class~~ Introducing ClientRequestFilter.java: A New Plugin for Applying Request Headers in the Authentication Filter Class Sep 10, 2024

tdcmeehan requested changes Sep 10, 2024

View reviewed changes

tdcmeehan requested changes Sep 25, 2024

View reviewed changes

tdcmeehan requested changes Oct 7, 2024

View reviewed changes

tdcmeehan requested changes Oct 9, 2024

View reviewed changes

SthuthiGhosh9400 requested review from steveburnett, a team, jaystarshot, feilong-liu and ClarenceThreepwood as code owners October 15, 2024 18:32

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from d797300 to 9fa7ae2 Compare October 15, 2024 18:36

tdcmeehan reviewed Dec 12, 2024

View reviewed changes

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from 9d848d1 to b49b2c1 Compare December 13, 2024 09:50

tdcmeehan requested changes Dec 13, 2024

View reviewed changes

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from 5a959b0 to 18e06fe Compare December 14, 2024 10:59

tdcmeehan requested changes Dec 16, 2024

View reviewed changes

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from bc440bc to 90678a2 Compare December 16, 2024 19:02

tdcmeehan requested changes Dec 17, 2024

View reviewed changes

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from b80a4d5 to 28c5aa4 Compare December 19, 2024 15:06

tdcmeehan requested changes Dec 20, 2024

View reviewed changes

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from a00c586 to b21ad93 Compare January 1, 2025 14:57

steveburnett requested changes Jan 3, 2025

View reviewed changes

presto-docs/src/main/sphinx/develop/client-request-filter.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/develop/client-request-filter.rst Outdated Show resolved Hide resolved

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from 02dba34 to c2bd746 Compare January 6, 2025 04:49

steveburnett previously approved these changes Jan 6, 2025

View reviewed changes

tdcmeehan previously approved these changes Jan 10, 2025

View reviewed changes

SthuthiGhosh9400 dismissed stale reviews from tdcmeehan and steveburnett via f7c2d9f January 14, 2025 07:31

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from c2bd746 to f7c2d9f Compare January 14, 2025 07:31

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from f7c2d9f to 9ace465 Compare January 16, 2025 04:17

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch 2 times, most recently from d5df908 to 7d72a35 Compare January 16, 2025 16:49

Add additional headers to the client request.

634d36c

Add ClientRequestFilter.java interface in Presto-spi module. Improve Request Headers in the Authentication Filter Class.

SthuthiGhosh9400 force-pushed the request-modifier-plugin branch from 7d72a35 to 634d36c Compare January 16, 2025 17:47

	private final CopyOnWriteArrayList<ClientRequestFilter> clientRequestFilters;
	private final List<ClientRequestFilter> clientRequestFilters;

	return Collections.unmodifiableList(clientRequestFilters);
	return ImmutableList.copyOf(clientRequestFilters);

		ClientRequestFilterContext context = new ClientRequestFilterContext(principal);
		Optional<Map<String, String>> extraHeaderValueMap = requestFilter.getExtraHeaders(context);

		Map<String, String> extraHeadersMap = extraHeadersMapBuilder.build();
		return new ModifiedHttpServletRequest(request, extraHeadersMapBuilder.build());

		Presto facilitates seamless integration of additional headers into client requests using the
		Client Request Filter plugin via the AuthenticationFilter class, enabling efficient and dynamic header management.

		The ``ClientRequestFilterFactory`` is responsible for creating instances of ``ClientRequestFilter``. It also defines
		the name of the filter, which is subsequently used as the header name in client requests.


		After installing a plugin that implements ``ClientRequestFilterFactory`` on the coordinator, the ``AuthenticationFilter`` class passes the ``principal`` object to the request filter, which returns the header values as a map.

		Presto uses the name of the request filter to determine whether the header is present in the blocklist.

	List<String> getHeaderNames();
	Set<String> getExtraHeaderKeys();

		``ClientRequestFilter`` interface provides two methods: ``getExtraHeaders()``,
		which returns header values as key-value pairs in a map, and ``getHeaderNames()``, which returns a list of header names used as the header names in client requests.

Introducing ClientRequestFilter.java: A New Plugin for Merging Additional Headers into Client Requests in the Authentication Filter #23380

Are you sure you want to change the base?

Introducing ClientRequestFilter.java: A New Plugin for Merging Additional Headers into Client Requests in the Authentication Filter #23380

Conversation

SthuthiGhosh9400 commented Aug 5, 2024 • edited Loading

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

tdcmeehan left a comment

Choose a reason for hiding this comment

steveburnett commented Aug 26, 2024

SthuthiGhosh9400 commented Aug 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdcmeehan commented Sep 6, 2024

SthuthiGhosh9400 commented Sep 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SthuthiGhosh9400 commented Sep 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SthuthiGhosh9400 commented Sep 26, 2024

tdcmeehan commented Sep 26, 2024

SthuthiGhosh9400 commented Sep 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SthuthiGhosh9400 commented Oct 8, 2024

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SthuthiGhosh9400 commented Oct 10, 2024

tdcmeehan commented Oct 15, 2024

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tdcmeehan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SthuthiGhosh9400 commented Dec 20, 2024

Choose a reason for hiding this comment

steveburnett left a comment

Choose a reason for hiding this comment

SthuthiGhosh9400 commented Jan 6, 2025

steveburnett left a comment

Choose a reason for hiding this comment

SthuthiGhosh9400 commented Jan 7, 2025

SthuthiGhosh9400 commented Aug 5, 2024 •

edited

Loading

SthuthiGhosh9400 commented Jan 14, 2025 •

edited

Loading