Java 17 Upgrade #25
Merged
Java 17 Upgrade #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaneja
reviewed
Oct 10, 2024
airbase/pom.xml
Outdated
| @@ -176,7 +176,7 @@ | |||
| <dep.packaging.version>0.163</dep.packaging.version> | |||
|
|
|||
| <!-- Dependency versions that should be the same everywhere. --> | |||
| <dep.guice.version>4.2.2</dep.guice.version> | |||
| <dep.guice.version>5.0.1</dep.guice.version> | |||
There was a problem hiding this comment.
Can this be upgraded to 6.0.0 ? Since we use javax.Inject in Presto this may be the highest version we can go for now.
There was a problem hiding this comment.
+1 to @aaneja
hi @imjalpreet is the build ok with 6.0.0? thanks!
There was a problem hiding this comment.
Sorry for missing this comment earlier. I've upgraded Guice to 6.0.0, and thanks @ZacBlanco for validating the build.
ZacBlanco
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
These are the changes we are currently running in tests for dual 8/17 support and it seems to work well
imjalpreet
force-pushed
the
upgradeToJava17
branch
from
108aef1 to
2dd1000
Compare
ZacBlanco
approved these changes
Jan 7, 2025
tdcmeehan
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: prestodb/presto#23788