Fixed grammar: 'Are you sure want to' to 'Are you sure that you want to' #1239
Conversation
|
While this fix improves upon the previous grammar, it's still incorrect. It is missing the clause "that". Instead of "Are you sure you want', the grammatically correct form is "Are you sure that you want". Please add a commit to fully comply grammatically. |
|
This is noted. I have added the clause "that" to make it "Are you sure that you want to". |
tinyfilemanager.php
Outdated
| @@ -3954,7 +3954,7 @@ function fm_show_header() | |||
| <div class="modal-dialog" role="document"> | |||
| <form class="modal-content rounded-3 shadow <?php echo fm_get_theme(); ?>" method="post" autocomplete="off"> | |||
| <div class="modal-body p-4 text-center"> | |||
| <h5 class="mb-3"><?php echo lng('Are you sure want to rename?') ?></h5> | |||
| <h5 class="mb-3"><?php echo lng('Are you sure you want to rename?') ?></h5> | |||
There was a problem hiding this comment.
Adding the subject ('you') is an incomplete fix. It needs also the clause 'that'. In this example, which applies to all sentences in this PR:
Are you sure you want(...)
Should instead be
Are you sure that you want(...)
nevermind: #1239 (comment)
akassama
changed the title
@ner00 To be fair, "that" is often omitted when the clause functions as the direct object. It's a matter of style, not grammar. Omission is pretty common in this context too, for instance Mac OS' Finder prompts similarly: "Are you sure you want to delete ...". |
I apologize about that, I'm not a native speaker. I was (wrongly) translating a grammatical equivalence from my language, where omitting "that" would be grammatically incorrect in that sentence. After reading more carefully about the usage of "that" in the English language, I stand corrected, it can be omitted in this situation, and in fact there are more cases where it can be omitted than otherwise. @akassama I have suggested something which is not necessary, nor grammatically relevant in context. Apologies. |
This pull request fixes a recurring grammar issue across the repository. The phrase "Are you sure want to" has been updated to "Are you sure that you want to" for clarity and correctness.