Merge pull request #708 from praekeltfoundation/endline_reminder

endline reminders
praekeltfoundation · Nov 14, 2023 · 0866924 · 0866924
2 parents cb2ffd1 + 767896e
commit 0866924
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/yal/assessments.py b/yal/assessments.py
@@ -438,7 +438,7 @@ async def state_handle_assessment_reminder_response(self):
             if error:
                 return await self.go_to_state("state_error")
 
-            if assessment_name.endswith("endline"):
+            if "endline" in assessment_name:
                 return await self.go_to_state("state_not_interested")
 
             return await self.go_to_state("state_pre_mainmenu")
@@ -447,7 +447,7 @@ async def state_not_interested(self):
         msisdn = utils.normalise_phonenumber(self.inbound.from_addr)
         whatsapp_id = msisdn.lstrip(" + ")
         data = {
-            "endline_survey_started": "",
+            "endline_survey_started": "not_interested",
         }
         error = await rapidpro.update_profile(whatsapp_id, data, self.user.metadata)
         if error:

diff --git a/yal/tests/test_assessments.py b/yal/tests/test_assessments.py
@@ -481,6 +481,7 @@ async def test_state_handle_assessment_reminder_response_not_interested(
             "assessment_reminder_type": "",
         },
     }
+
     tester.assert_metadata("assessment_reminder_name", "")
     tester.assert_metadata("assessment_reminder_sent", "")
     tester.assert_metadata("assessment_reminder_type", "")
@@ -496,17 +497,25 @@ async def test_state_handle_assessment_reminder_response_not_interested_endline(
     await tester.user_input("I'm not interested")
     tester.assert_state("state_not_interested")
 
-    request = rapidpro_mock.tstate.requests[1]
-    assert json.loads(request.body.decode("utf-8")) == {
+    request_one = rapidpro_mock.tstate.requests[1]
+    assert json.loads(request_one.body.decode("utf-8")) == {
         "fields": {
             "assessment_reminder_name": "",
             "assessment_reminder_sent": "",
             "assessment_reminder_type": "",
         },
     }
+
+    request_two = rapidpro_mock.tstate.requests[2]
+    assert json.loads(request_two.body.decode("utf-8")) == {
+        "fields": {
+            "endline_survey_started": "not_interested",
+        },
+    }
     tester.assert_metadata("assessment_reminder_name", "")
     tester.assert_metadata("assessment_reminder_sent", "")
     tester.assert_metadata("assessment_reminder_type", "")
+    tester.assert_metadata("endline_survey_started", "not_interested")
     tester.assert_message(
         "\n".join(
             [