Apply manual cleanups/refactorings and fixes #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
commented
Apr 30, 2024
| if (bind) DeviceContext.PSSetShaderResource(slot, srv); | ||
| if (bind) DeviceContext.PSSetShaderResource(slot, srv!); |
There was a problem hiding this comment.
This looks to be an incorrect NRT in Vortice.Windows. null is actually valid here, and the other cases below.
Comment on lines
-1240
to
+1221
| Box? subregion = new Box((int)bufferOffsetInBytes, 0, 0, (int)(sizeInBytes + bufferOffsetInBytes), 1, 1); | ||
| if (isUniformBuffer) subregion = null; | ||
| Box subregion = new Box((int)bufferOffsetInBytes, 0, 0, (int)(sizeInBytes + bufferOffsetInBytes), 1, 1); | ||
|
|
||
| if (isUniformBuffer) | ||
| subregion = default; |
There was a problem hiding this comment.
null implies default internal to Vortice.
Comment on lines
+118
to
+119
| Compiler.Compile(description.ShaderBytes, null!, null!, | ||
| description.EntryPoint, null!, |
There was a problem hiding this comment.
null is valid for D3DCompiler. It's not properly annotated.
Comment on lines
-259
to
+267
| buffer0.mutability = MTLMutability.Mutable; | ||
| buffer1.mutability = MTLMutability.Mutable; |
There was a problem hiding this comment.
This was an actual issue. See surrounding code.
smoogipoo
force-pushed
the
manual-touchups
branch
from
cf823e7 to
c0cb45b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through every file in the
Veldridproject and looked at where the IDE was hinting me to look. Applied the easier fixes, but left the harder stuff (e.g. VK suffers from synchronisation issues all over the place) for a later point in time.I'll document each important change as a review.